Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport translation changes to release/0.14.0 branch #4603

Merged
merged 36 commits into from
Jul 9, 2019

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Jul 9, 2019

Status

Ready for review

Description of Changes

Contains cherry-picked translation changes from #4599 and #4600

Testing

  • CI passes
  • Ensure you can run make -C securedrop update-user-guides

rmol added 30 commits July 9, 2019 14:19
(cherry picked from commit 3709576)
contributors:
  Ahmad Gharbeia
  ButterflyOfFire
  Erin McConnell
  Thalia Rahme

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit e3c4553)
contributors:
  Adolfo Jayme-Barrientos
  Allan Nordhøy
  Benet (BennyBeat) R. i Camps
  Carles Figuerola
  Joan Montané

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 50b24cd)
contributors:
  Curtis Baltimore
  Robin Schubert
  kwadronaut

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 02beed1)
contributors:
  Adrian
  Dimitris Maroulidis
  Panagiotis Tabakis

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit b82b746)
contributors:
  Allan Nordhøy
  Daniel Arauz
  Zuhualime Akoochimoya

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 9bd90b0)
contributors:
  AO
  Alain-Olivier

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 784c5b1)
contributors:
  AbhayKaushik
  Muhammad Usman

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit a74db89)
contributors:
  Allan Nordhøy
  Oktavia
  Sveinn í Felli

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 11f269d)
contributors:
  Beatrice Martini
  Claudio Arseni

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 7dee808)
contributors:
  Allan Nordhøy
  Øyvind Bye Skille

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 62620c1)
contributors:
  Allan Nordhøy
  Pander
  Thom
  Yarno Ritzen
  kwadronaut

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit fea11ce)
contributors:
  Allan Nordhøy
  Caio Volpato
  Cláudio Carvalho
  Erin McConnell
  communiaa

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 4eea03b)
contributors:
  Andrada Fiscutean
  Jobava

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit ec815ae)
contributors:
  Allan Nordhøy
  Andrey
  Maria Ovsyannikova

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit d9c914f)
contributors:
  A. Nonymous
  Allan Nordhøy
  Jonas Franzén

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit d7fd863)
contributors:
  Allan Nordhøy
  Kaya Zeren
  Orhan
  Volkan

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit ff848f1)
contributors:
  Chi-Hsun Tsai

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: a91cbeb

(cherry picked from commit 8058b2b)
contributors:
  erinm

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 7d90579)
contributors:
  Benet (BennyBeat) R. i Camps

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 88d560d)
contributors:
  Allan Nordhøy

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 287ea24)
contributors:
  Allan Nordhøy

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 74da582)
contributors:
  Oktavia

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 9749c45)
contributors:
  Claudio Arseni
  rmol

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 7962070)
contributors:
  Øyvind Bye Skille

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 4716c5f)
contributors:
  Allan Nordhøy
  Thom

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 25eb778)
contributors:
  communiaa

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit edeadf3)
contributors:
  rmol

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit f5b862c)
rmol added 6 commits July 9, 2019 14:28
contributors:
  Jonas Franzén

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit ff48d0d)
contributors:
  Volkan

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 3210ac0)
contributors:
  Allan Nordhøy

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 6c8324f

(cherry picked from commit 27c4d73)
contributors:
  rmol

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 8a213b8

(cherry picked from commit bdf7fb8)
@redshiftzero
Copy link
Contributor

redshiftzero commented Jul 9, 2019

In lieu of the translation test job (unless it finishes before we do) we are running page layout tests manually to speed up merge:

@redshiftzero:
'ar' ✅
'ca' ✅
'de_DE' ✅
'el' ✅
'es_ES' ✅
'fr_FR' ✅
'hi' ✅
'is' ✅

@rmol: ['it_IT', 'nb_NO', 'nl', 'pt_BR', 'ro', 'ru', 'sv', 'tr', 'zh_Hant']

@redshiftzero
Copy link
Contributor

Confirmed:

  1. Makefile related due to changes introduced in develop in Make Python 3 the default for development #4544 but not on the release branch or
  2. test related (39acd2d)

All page layout tests passed locally for me on this branch in 'ar', 'ca', 'de_DE', 'el', 'es_ES', 'fr_FR', 'hi', 'is'. Once the other languages are confirmed passed by @rmol and #4600 is approved (I'm going to look at that now) this is good to merge.

@rmol
Copy link
Contributor Author

rmol commented Jul 9, 2019

Page layout tests passed locally for me with locales 'it_IT', 'nb_NO', 'nl', 'pt_BR', 'ro', 'ru', 'sv', 'tr', 'zh_Hant'.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmol, #4600 is approved so merging

@redshiftzero redshiftzero merged commit 6a943b5 into freedomofpress:release/0.14.0 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants