Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.0] Remove v3 onion secrets when transitioning to ssh over local #4798

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Sep 11, 2019

Status

Ready for review

Description of Changes

Backports changes from #4794 to the release/1.0.0 branch

Testing

Ensure changes/commits are identical to #4794

- v2 aths secret file pattern does not match the one for v3
- Use async task for reboot for more immediate feedback
- Instruct admin to run tailsconfig to update the ssh config on tails workstation

(cherry picked from commit 2dc29cd)
@eloquence eloquence added this to Ready for review in SecureDrop Team Board Sep 11, 2019
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

Codecov Report

Merging #4798 into release/1.0.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.0.0    #4798   +/-   ##
==============================================
  Coverage          81.74%   81.74%           
==============================================
  Files                 49       49           
  Lines               3418     3418           
  Branches             392      392           
==============================================
  Hits                2794     2794           
  Misses               533      533           
  Partials              91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb7cb0...e827698. Read the comment docs.

@zenmonkeykstop zenmonkeykstop merged commit e729639 into release/1.0.0 Sep 11, 2019
SecureDrop Team Board automation moved this from Ready for review to Done Sep 11, 2019
@emkll emkll deleted the 4794-to-1.0.0 branch October 8, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants