[docs] Instruct localization manager to squash translation commits #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmol
requested review from
emkll,
kushaldas,
redshiftzero and
zenmonkeykstop
as code owners
eloquence
changed the title
kushaldas
approved these changes
Sep 16, 2019
emkll
added a commit
that referenced
this pull request
Sep 16, 2019
[1.0.0] backport: #4807 Instruct localization manager to squash translation commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Adds instructions for the localization manager to squash translation commits down to one per language before merging. This keeps translations easy to review when source strings have had to be translated more than once because of errors that had to be corrected, or to incorporate suggestions from the feedback period.
Fixes #4625.
Testing
make docsPush your branch and create a pull requestand see if you find the instructions in the new note intelligible.Deployment
Docs only.
Checklist
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locally