[1.0.0] Backport #4819 Fix journalist test_delete_one #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JournalistNavigationStepsMixin's _journalist_delete_one is more reliable with an ActionChains move/click incantation, but switching to that in the functional test safe_click* methods breaks a bunch of other tests, so I'm just rolling with the Selenium voodoo. (cherry picked from commit fcce813)
conorsch
requested review from
heartsucker,
kushaldas and
redshiftzero
as code owners
kushaldas
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Description of Changes
JournalistNavigationStepsMixin's _journalist_delete_one is more
reliable with an ActionChains move/click incantation, but switching to
that in the functional test safe_click* methods breaks a bunch of
other tests, so I'm just rolling with the Selenium voodoo.
(cherry picked from commit fcce813)
Testing
Please make sure the commits are the same as those in #4819.