New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport changelog entries from 1.0.0 and updates to 1.1.0~rc1 #4840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the backport @kushaldas!
- It seems like
molecule/shared/stable.ver
changes were not backported [0] , this is required for upgrade boxes. I just checked, and the stable.ver file was correctly updated in the release branch [1]. - In the past, we've committed each rc commit for posterity in develop (see [2]). Could you please add the commits for rc2,3 and 4? They won't affect the diff but it would be good to have them.
[0] https://github.com/freedomofpress/securedrop/blob/backport_changelog_1/molecule/shared/stable.ver#L1
[1] https://github.com/freedomofpress/securedrop/blob/release/1.0.0/molecule/shared/stable.ver
[2] https://github.com/freedomofpress/securedrop/pull/4389/commits
1a88233
to
b53447e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4840 +/- ##
========================================
Coverage 81.74% 81.74%
========================================
Files 49 49
Lines 3418 3418
Branches 392 392
========================================
Hits 2794 2794
Misses 533 533
Partials 91 91 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @kushaldas , good to merge when CI passes.
There's a seemingly unrelated app error /flake in https://circleci.com/gh/freedomofpress/securedrop/34576 , which we should restart and ensure it passes prior to merge.
Status
Ready for review
Description of Changes
Adds the changelog entries from 1.0.0 release and
updates release to 1.1.0~rc1