Upgrade boxes for SecureDrop 1.0.0 #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The in securedrop-staging.yml, the grsec role is bring run before the common role. [1] : https://github.com/freedomofpress/securedrop/blob/9f32d46136861546af556d3f54d92e31cebe2eb0/install_files/ansible-base/securedrop-staging.yml
During 1.0, we did not test the v3 keypair generation in the upgrade scenario. Makes sense: we only run that scenario *after* a release is final. The git-repo-root logic assumed we were in Tails or running against normal staging VMs. In the vagrant-package logic (which builds "upgrade" boxes for testing), the proper path structure requires that filepaths be relative to the secondary git repo, cloned in order to prepare an old version from the known-good tag. This var override ensures that the v3 keys are stored inside the secondary git repo. We could instead update the rev-parse logic to be relative to the role, but that'd require additional testing in Tails, and this works just as well.
Use v2 and v3 onion services
23 tasks
Codecov Report
@@ Coverage Diff @@
## develop #4857 +/- ##
========================================
Coverage 81.74% 81.74%
========================================
Files 49 49
Lines 3418 3418
Branches 392 392
========================================
Hits 2794 2794
Misses 533 533
Partials 91 91Continue to review full report at Codecov.
|
zenmonkeykstop
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4854, #4724
Test plan
Deployment
Dev env only
Checklist
If you made non-trivial code changes: