[1.1.0] Backport source guide updates #4953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The "Get Tor" instructions as written didn't work; the email autoresponder requires the OS to be specified, and the GitHub downloads are currently not available. - The instructions suggested visiting the .onion address _before_ "choosing who to submit to". - Added a recommendation to verify the .onion address against the SecureDrop Directory - Used more common terms in a couple of places (e.g., "USB Flash Drive" instead of "USB Key"), simplified Flag for Reply language - Wrap to 80 characters (cherry picked from commit abb2a90)
- GitLab mirror rewording - Note that Tor browser usage can be detected - Add .onion address for securedrop.org - Other minor edits (cherry picked from commit 53e978e)
(cherry picked from commit 8375ee5)
(cherry picked from commit 85e6e96)
eloquence
requested review from
emkll,
kushaldas,
redshiftzero and
zenmonkeykstop
as code owners
redshiftzero
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Description/review in #4880. Given the broken GitHub link and incomplete security guidance, worth backporting into the release branch. Linter is happy.