Changed newsroom logo alt tag to 'Logo Image' (#4280)

[DrGFreeman]

Status

Ready for review

Description of Changes

Related to #4280 (does not fix completely).

Changes proposed in this pull request:

Change the <alt> tag of the Newsroom logo image in the source application from SecureDrop to Logo Image.

Note that this change addresses item 1) of #4280 but does not implement the dynamic Newsroom name suggested in item 2) of #4280.

Testing

Run make dev and login to the Source Interface.

Use the brower's inspection feature to verify that the <alt> tag of the logo is set to Logo Image. Perform this verification on the index page as well as in the other pages accessible via the Source Interface.

Checklist

If you made changes to the server application code:

• Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

• Linting and tests (make -C admin test) pass in the admin development container

N/A.

If you made changes to the system configuration:

• Configuration tests pass

N/A.

If you made non-trivial code changes:

• I have written a test plan and validated it for this PR

N/A.

If you made changes to documentation:

• Doc linting (make docs-lint) passed locally

N/A.

If you added or updated a code dependency:

Choose one of the following:

• I have performed a diff review and pasted the contents to the packaging wiki
• I would like someone else to do the diff review

N/A.

[zenmonkeykstop]

Thanks for the PR! One improvement that could be made would be to make "Logo Image" an i18nable string, by wrapping it in a call to gettext().

[DrGFreeman]

@zenmonkeykstop, changes implemented as per your change request.

[zenmonkeykstop]

i18n working - LGTM!