Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5522 no typing module required on Focal #5527

Merged
merged 1 commit into from Oct 1, 2020

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Sep 24, 2020

Status

Ready for review

Description of Changes

Fixes #5522

We need the typing module only on Xenial, but not on Focal.

Testing

  • CI is green
  • make build-debs-focal && molecule converge -s libvirt-staging-focal
  • login to the app-staging and check if any systemctl service is failing

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

We need the typing module only on Xenial, but not on Focal.
@emkll emkll added this to Ready for Review in SecureDrop Team Board Sep 24, 2020
@zenmonkeykstop zenmonkeykstop self-assigned this Sep 24, 2020
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan passes, systemctl list-units --failed shows only vboxadd service failures (artifact of using converted virtualbox images). LGTM once CI passes (looks like staging-test-with-rebase flakes are not yet completely eliminated)

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspected both xenial and focal packages produced by this branch, typing is included in the xenial virtualenv shipped by the built package, and not in the one shipped in the focal package.

Systemctl units are not failing in focal, and CI is green 🚀

@emkll emkll merged commit 707cc14 into develop Oct 1, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Oct 1, 2020
@emkll emkll deleted the no_typing_required_on_focal branch October 1, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

securedrop_shredder, securedrop_source_deleter and securedrop_rqrequeue is failing on Focal
3 participants