Add type annotations to secure_tempfile.py and models.py #5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabla-c0d3
commented
Sep 27, 2020
nabla-c0d3
commented
Sep 27, 2020
nabla-c0d3
force-pushed
the
typing-annotations-models-and-secure-tempfile
branch
from
3f4a9e1
to
37ceed5
Compare
nabla-c0d3
force-pushed
the
typing-annotations-models-and-secure-tempfile
branch
from
37ceed5
to
fe75388
Compare
rmol
suggested changes
Oct 16, 2020
Add type annotations to upload-screenshots.py Add type annotations to request_that_secures_file_uploads.py Add type annotations to models.py Fix type Fix type Remove legacy tests Add more specific types to _secure_file_stream
nabla-c0d3
force-pushed
the
typing-annotations-models-and-secure-tempfile
branch
from
fe75388
to
85a4582
Compare
rmol
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready.
Description of Changes
To help with #4399 , this PR adds type annotations in the following files: