Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n merge for 1.6.0 release #5560

Merged
merged 19 commits into from Oct 7, 2020
Merged

I18n merge for 1.6.0 release #5560

merged 19 commits into from Oct 7, 2020

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Oct 7, 2020

Status

Ready for review.

Description of Changes

Translations for 1.6.0 release.

Changes proposed in this pull request:

Testing

Deployment

Translations will be shipped by the securedrop-app-code debian package

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

contributors:
  Thalia Rahme
  erinm

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Benet (BennyBeat) R. i Camps
  Joan Montané

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Honza Cibulka
  erinm
  michaela-bot

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Ettore Atalan
  Robin Schubert

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Adrian
  Dimitris Maroulidis
  John Hensley

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Fernando Ramos Orihuela
  Gonzalo Bulnes Guilpain
  John Hensley
  Zuhualime Akoochimoya
  erinm

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  AO Localization Lab
  erinm

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Drashti

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Oktavia
  Sveinn í Felli

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Claudio Arseni

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Øyvind Bye Skille

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  John Hensley
  Thom

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  John Hensley
  communiaa
  erinm
  sobeitnow0
  yyyyyyyan

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Jobava
  erinm
  robbpa

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Adham Kurbanov
  Andrey

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  John Hensley
  erinm

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
contributors:
  Jonas Waga

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: d34ba2a
@kushaldas kushaldas changed the title I18n merge I18n merge for 1.6.0 release Oct 7, 2020
@emkll emkll added this to Under Review in SecureDrop Team Board Oct 7, 2020
@emkll emkll self-requested a review October 7, 2020 12:44
@kushaldas
Copy link
Contributor Author

I did one round of visual inspection of the changes and also ran around 80% of the languages in test locally.

emkll
emkll previously approved these changes Oct 7, 2020
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushaldas, tests are passing and also did a visual inspection of the strings.

@emkll emkll dismissed their stale review October 7, 2020 13:14

Forgot to test for missing translations

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ran the script (with modified test strings) described in the test plan in #5243 (comment) , it seems like no strings are missing

@emkll emkll merged commit bee63b1 into develop Oct 7, 2020
SecureDrop Team Board automation moved this from Under Review to Done Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants