Updates pytest pluggy testinfra molecule and the universe #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushaldas
force-pushed
the
updates_pytest_pluggy_testinfra_molecule_and_the_universe
branch
from
05531b1
to
8ff1fb1
Compare
kushaldas
requested review from
conorsch,
emkll and
redshiftzero
as code owners
12 tasks
emkll
suggested changes
Oct 21, 2020
There was a problem hiding this comment.
Thanks @kushaldas , went though the test plan and observe a few failures in some scenarios. Also, I did not test all the cases (Qubes and Virtualbox scenarios)
- make build-debs
- make build-debs-focal
- make fetch-tor-packages
- molecule test -s libvirt-staging-xenial
- molecule test -s libvirt-staging-focal
- molecule converge virtualbox-staging-xenial (did not test)
- molecule converge -s qubes-staging-focal (did not test)
- molecule converge -s qubes-staging-xenial (did not test)
- ❗
make testinfraon prod VMs looks like testinfra version needs to be updated in https://github.com/freedomofpress/securedrop/blob/updates_pytest_pluggy_testinfra_molecule_and_the_universe/admin/requirements-testinfra.txt - ❗
make upgrade-startMolecule syntax error - ❗
make upgrade test-localcan't run because start command above doesn't work - ❗
make upgrade-start-qaMolecule syntax error - ❗
make upgrade-test-qacant run because start command above doesn't work
|
Confirmed that the following pass:
|
|
Wondering if I should update this? @emkll what do you think? |
|
It seems like it just consists of renaming the files, I think it's worth addressing as part of this PR, good catch |
We need the newer version of pluggy and pytest to make sure that the tests are running on Focal and Xenial in the same way.
Also updates pluggy+molecule-vagrant as dependency Why? Because the testinfra updates requires molecule update. Updated the molecule files for the new molecule in the `libvirt-staging-xenial` scenario. Also contains all testinfra tests update, as pytest_namespace is dropped in the pytest. `molecule test -s libvirt-staging-xenial` now works.
Updates the pytest tests for the newer version of pytest and also molecule.yml as required for newer version of molecule.
It updates two molecule scenario: - fetch-tor-packages - libvirt-staging-focal In libvirt-staging-focal create.yml also updated for molecule_vagrant update.
kushaldas
force-pushed
the
updates_pytest_pluggy_testinfra_molecule_and_the_universe
branch
from
958c778
to
a11647a
Compare
This was referenced Oct 28, 2020
|
Hey @kushaldas was just testing the libvirt-focal scenario, is it expected that tests not run? After running |
|
@emkll can you please paste the output of |
|
This is the problem, as the host is already Python3.7 on Buster. @emkll can you please create a fresh virtualenv and install develop-requirements.txt from this branch and try? |
|
I ran through all the test scenarios. All but
|
That worked, thanks! My mistake was installing the updated requirements in an existing virtualenv. Developers will need to recreate a new virtualenv or manually remove |
|
I retried the failures on
I'm inclined to merge this and address the failures separately, since two out of three are happening on |
emkll
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Based on @rmol and @zenmonkeykstop 's review, I second @rmol 's comment, good to merge as-is, to unblock work on Focal. Let's identify any problems that may arise from these major version bumps, and open follow-up issues as needed
All changes here are to test requirements and therefore should not need a diff review.
emkll
deleted the
updates_pytest_pluggy_testinfra_molecule_and_the_universe
branch
This was referenced Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5584
Testing
We have to test each and every scenario. Note: we have to update each of the below points with proper test steps.
make testinfraon prod VMsmake upgrade-startmake upgrade test-localmake upgrade-start-qamake upgrade-test-qaDeployment
Any special considerations for deployment? Consider both:
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locallyIf you added or updated a code dependency:
Choose one of the following: