Restore lost SDConfig.env attribute
#5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
Not having it means that the dev server does not run in debug mode, preventing reloading when code is changed.
rmol
force-pushed
the
5594-fix-lost-sdconfig-env
branch
from
34af0f1
to
1a89a90
Compare
emkll
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5594.
Testing
git checkout -b 5594-fix-lost-sdconfig-env origin/5594-fix-lost-sdconfig-envmake devsecuredrop/journalist_app/main.pyto trigger a reload, and confirm that the change is detected.Deployment
This is simply restoring old logic lost in the refactoring for #5532; it should not change production configurations.
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made non-trivial code changes: