Updated Tor Browser UA matches to include recent MacOS versions #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
requested review from
kushaldas and
redshiftzero
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5647 +/- ##
========================================
Coverage 53.10% 53.10%
========================================
Files 50 50
Lines 5928 5928
Branches 530 530
========================================
Hits 3148 3148
Misses 2678 2678
Partials 102 102 Continue to review full report at Codecov.
|
emkll
force-pushed
the
5626-update-osx-ua-check
branch
from
175988c
to
da94560
Compare
|
(rebased on latest develop) |
emkll
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
- Open
127.0.0.1:8080and confirm that the Source Interface appears with no TBB warning. - Open
127.0.0.1:8080in a different browser and confirm that the warning does appear - If available, repeat the steps above on a non-MacOS (Linux) system and confirm consistent behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5626 .
Adds @harrislapiroff's update to the TBB User Agent regex to include versions of MacOS from 00 to 99 :)
Testing
make devon this branch on a MacOS system with the latest Tor BrowserOpen Tor Browser and update the config: open
about:configUpdate the proxy settings to allow localhost requests by searching for
network.proxy.no_proxies_onand updating its value to127.0.0.1Open
127.0.0.1:8080and confirm that the Source Interface appears with no TBB warning.Open
127.0.0.1:8080in a different browser and confirm that the warning does appearIf available, repeat the steps above on a non-MacOS system and confirm consistent behaviour.
Deployment
Will be deployed with next release after merge.
Checklist
If you made non-trivial code changes:
Choose one of the following: