Faster unit tests by re-using GPG directory #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabla-c0d3
changed the title
nabla-c0d3
force-pushed
the
faster-tests-with-gpg-fixture
branch
from
e1322a8
to
b3b80db
Compare
nabla-c0d3
changed the title
nabla-c0d3
changed the title
|
@nabla-c0d3 Rebasing should fix the safety check failure (resolved via #5686) |
nabla-c0d3
force-pushed
the
faster-tests-with-gpg-fixture
branch
from
b3b80db
to
c2b7a47
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5683 +/- ##
========================================
Coverage 85.54% 85.54%
========================================
Files 52 52
Lines 3771 3771
Branches 474 474
========================================
Hits 3226 3226
Misses 440 440
Partials 105 105 Continue to review full report at Codecov.
|
kushaldas
requested changes
Jan 6, 2021
There was a problem hiding this comment.
Rest looks good. Thank you @nabla-c0d3 for this. It will surely speedup the tests.
Fix lint Fix types
nabla-c0d3
force-pushed
the
faster-tests-with-gpg-fixture
branch
from
c2b7a47
to
50853df
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready.
Description of Changes
This PR fixes #4331 by updating the
configfixture to have it re-use the same GPG directory across all tests via asessionscope.More specifically, the code that imports the test GPG key within the
configfixture takes 2s to run on my laptop. This adds a 2s setup call to every single unit test that relies on theconfigfixture. A lot of tests do use this fixture (directly or indirectly). For example, the first parallel run of app-tests on CircleCI takes 22 minutes to complete for this PR, instead of 28 minutes.However, this PR is more about improving the developer experience when constantly running a few tests locally, while building a feature. Having a 2s delay on each test makes iterating on a feature much slower.