New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add passphrases.py AppArmor rule #5705
Conversation
8231109
to
c7ece37
Compare
Added wordlists/ per @rmol 's feedback, should be ready for re-review now |
install_files/ansible-base/roles/build-securedrop-app-code-deb-pkg/files/usr.sbin.apache2
Outdated
Show resolved
Hide resolved
The file no longer exists
fb77b89
to
387a803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge once green. Checked the latest, no apparmor violations seen, journalist interface user addition working, source generation fine.
Codecov Report
@@ Coverage Diff @@
## develop #5705 +/- ##
========================================
Coverage 85.58% 85.58%
========================================
Files 52 52
Lines 3773 3773
Branches 471 471
========================================
Hits 3229 3229
Misses 439 439
Partials 105 105 Continue to review full report at Codecov.
|
Status
Ready for review
Description of Changes
Fixes #5703
Testing
From scratch:
make build-debs
andmake staging
on this branchOR, if you already have a 1.7.0-rc1 server (virtualized or hardware) already running:
/etc/apparmor.d/usr.sbin.apache2
and add the line in the AppArmor configsudo service apparmor teardown
sudo service apparmor restart
Deployment
These changes for both new and existing installs will be handled by the securedrop-app-code debian package.
Checklist
If you made non-trivial code changes: