Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-install setuptools-scm <6 in venv #5877

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Pre-install setuptools-scm <6 in venv #5877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcee956
Pre-install setuptools-scm <6 in venv
Mar 18, 2021
68e7e9c
Installs dependency in the debian virutalenv
kushaldas Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions install_files/ansible-base/roles/build-securedrop-app-code-deb-pkg/tasks/translations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
---

- name: Install SecureDrop Python requirements in virtualenv for translation work
shell: |
python3 -m venv /tmp/securedrop-app-code-i18n-ve
shell: >
set -e &&
python3 -m venv /tmp/securedrop-app-code-i18n-ve &&
/tmp/securedrop-app-code-i18n-ve/bin/pip3 install "setuptools-scm==5.0.2" &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that hash checking is not performed on this dependency, but that was already the case, as it was being installed as a build dependency via python-dateutil's setup.py.

/tmp/securedrop-app-code-i18n-ve/bin/pip3 install --no-deps --no-binary :all: --require-hashes -r {{ securedrop_app_code_prep_dir }}/requirements.txt
tags:
- pip
Expand Down
1 change: 1 addition & 0 deletions install_files/securedrop-app-code/debian/rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ override_dh_virtualenv:
dh_virtualenv \
--python=/usr/bin/python3 \
--builtin-venv \
--preinstall setuptools-scm==5.0.2 \
--extra-pip-arg "--verbose" \
--extra-pip-arg "--no-deps" \
--extra-pip-arg "--no-binary=:all:" \
Expand Down