Wordlist removals and translation updates for next SecureDrop release #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloquence
moved this from Next sprint candidates
to SecureDrop Sprint #70 (5/5-5/19)
in SecureDrop Team Board
eloquence
moved this from SecureDrop Sprint #71 (5/20-6/2)
to Ready for Review
in SecureDrop Team Board
eloquence
changed the title
eloquence
force-pushed
the
wordlist-removals
branch
from
c6eb5d2
to
8d3658a
Compare
|
Since it's a small change, I've pulled in one low-hanging fruit string improvement as well, suggested in https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=e3e9531df602610b, as part of an overall review of Weblate comments (#5869). |
eloquence
force-pushed
the
wordlist-removals
branch
from
8d3658a
to
c16c952
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5895 +/- ##
========================================
Coverage 85.12% 85.12%
========================================
Files 55 55
Lines 3865 3865
Branches 480 480
========================================
Hits 3290 3290
Misses 463 463
Partials 112 112
Continue to review full report at Codecov.
|
zenmonkeykstop
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review. See previously: #5357, #1546; 366c657.
Description of Changes
Removes potentially offensive words (alone or in combination) from the SecureDrop wordlists. Among other things, SecureDrop uses adjectives and nouns to generate journalist designations, and while we cannot avoid all potentially offensive combinations, we can exclude some words that are almost always inappropriate in journalist designations or passphrases.
Addresses translation feedback by pappasadrian and KwadroNaut from https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=e3e9531df602610b