Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash check for setuptools-scm #5903

Closed

Conversation

EdwardPrentice
Copy link

@EdwardPrentice EdwardPrentice commented Apr 16, 2021

Mandates that the hash for setuptools-scm at version 5.0.2 is correct to avoid tampering

Mandates that the hash for setuptools-scm at version 5.0.2 is correct to avoid tampering
@zenmonkeykstop
Copy link
Contributor

Hi @EdwardPrentice apologies for the delayed response. This is a definite improvement but it may not get used in its current form, as the next release will be Focal-only and hence >Python 3.6, so we can update for that.

@EdwardPrentice
Copy link
Author

Sounds good! Gives an idea of how to do it at least!

@emkll emkll added this to In Development in SecureDrop Team Board Apr 28, 2021
@conorsch
Copy link
Contributor

conorsch commented May 3, 2021

Thank you, @EdwardPrentice, for this PR. We just merged #5888 which I believe resolves the concern you raised here—specifically https://github.com/freedomofpress/securedrop/pull/5888/files#diff-8be480111ec0858827980d7f974731ea7c28f24065f7061558ea0464beb4b4d0L7-R7

In that PR, @zenmonkeykstop opted to create a new requirements file, but your trick with the process substitution was clever! Hopefully we'll be able to pare these requirements files down in the near future.

I'm closing this PR as the underlying issue has been resolved, but don't hesitate to re-open if you disagree. Hope to see you around soon!

@conorsch conorsch closed this May 3, 2021
@eloquence eloquence removed this from In Development in SecureDrop Team Board May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants