Make <time datetime= into valid HTML by using a custom jinja tag #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…dd new filter to templates (fixes #6057) Add newline to end of template_filters.py Remove locale argument from html_datetime_format Remove surplus line breaks
zenmonkeykstop
force-pushed
the
fix-6057
branch
from
c53d95d
to
76c1e47
Compare
zenmonkeykstop
commented
Sep 20, 2021
There was a problem hiding this comment.
HTML validation passes when a reply is present, LGTM! Thanks @anorthall!
conorsch
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Looks good, thanks for juggling the commits @zenmonkeykstop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Resubmitting @anorthall's changes from #6058, recovered after a broken rebase)
Status
Ready for review
Description of Changes
Fixes #6057
Change the direct call to
__str__()into a call tostrftime()to meet the requirement of not having more than 3 decimal places for seconds on HTML. Now, no decimal places are displayed. I decided to implement this instead of the truncate filter as you cannot truncate the datetime object without first converting it to a string.Testing
Open the website and validate the HTML.
Deployment
No special measures required.
Checklist