Display "Forgot you codename?" codename-hint link only on initial login #6130

DrGFreeman · 2021-10-08T03:44:08Z

Status

Ready for review

Description of Changes

Changes proposed in this pull request:

Display the "Forgot you codename?" link to the codename-hint section in the /submit flashed message only on the source's initial login (i.e. do not display the link after the source logged in using their codename).

Add functional test to verify the above behavior. Also include verification of the first submission specific message.

Testing

Verify link does not show on second login - from /logout

Access the Source Interface and click "GET STARTED".
Take note of the codename on /generate and click "SUBMIT DOCUMENTS".
On /lookup, click "LOGOUT".
On /logout click "LOG IN".
Enter the codename noted in 2 and click "CONTINUE".
On /lookup enter a message and click "SUBMIT".
- Verify that the flashed message does not include the "Forgot you codename?" link

Verify link does not show on second login - from /

Access the Source Interface and click "GET STARTED".
Take note of the codename on /generate and click "SUBMIT DOCUMENTS".
On /lookup, click "LOGOUT".
Click on the SecureDrop logo to return to /.
On / click "LOG IN".
Enter the codename noted in 2 and click "CONTINUE".
On /lookup enter a message and click "SUBMIT".
- Verify that the flashed message does not include the "Forgot you codename?" link.

Verify link shows on first login

Access the Source Interface and click "GET STARTED".
Take note of the codename on /generate and click "SUBMIT DOCUMENTS".
On /lookup enter a message and click "SUBMIT".
- Verify that the flashed message includes the "Forgot you codename?" link.

Deployment

Any special considerations for deployment? Consider both:

Upgrading existing production instances.
New installs.

N/A.

Checklist

If you made changes to the server application code:

Linting (make lint) and tests (make test) pass in the development container

If you made changes to `securedrop-admin`:

Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

Configuration tests pass

If you added or removed a file deployed with the application:

I have updated AppArmor rules to include the change

If you made non-trivial code changes:

I have written a test plan and validated it for this PR

Choose one of the following:

I have opened a PR in the docs repo for these changes, or will do so later
I would appreciate help with the documentation
These changes do not require documentation

If you added or updated a production code dependency:

Production code dependencies are defined in:

admin/requirements.in
admin/requirements-ansible.in
securedrop/requirements/python3/securedrop-app-code-requirements.in

If you changed another requirements.in file that applies only to development
or testing environments, then no diff review is required, and you can skip
(remove) this section.

Choose one of the following:

I have performed a diff review and pasted the contents to the packaging wiki
I would like someone else to do the diff review

DrGFreeman · 2021-10-15T03:47:05Z

Added functional tests, rebased to develop and set status to "Ready for review".

DrGFreeman · 2021-10-20T11:43:47Z

Rebased to develop following version 2.1.0 release.

conorsch · 2021-10-21T16:33:52Z

Hey there, thanks @DrGFreeman! I believe @creviera expressed an interest in reviewing this, so I'm tagging her in here. Likely next week sometime, given our current schedule.

sssoleileraaa · 2021-10-25T18:19:59Z

securedrop/source_templates/first_submission_flashed_message.html

@@ -1,8 +1,10 @@
 <section class="message">
  <h2>{{ gettext('Success!') }}</h2>
  <p>{{ gettext('Thank you for sending this information to us. Please check back later for replies.') }}
+    {% if new_user_codename %}
    <a href="#codename-hint">
      {{ gettext('Forgot your codename?') }}


[nit] this would look better on a new line

Hi @creviera, thanks for the review. Just to be sure, you mean moving the "Forgot your codename?" item on a separate line like this?

yup, looks great!

sssoleileraaa

works as expected, just one nitpicky comment, so i'll let this sit for a few after approving

Testing

Verify link does not show on second login - from /logout

Access the Source Interface and click "GET STARTED".
Take note of the codename on /generate and click "SUBMIT DOCUMENTS".
On /lookup, click "LOGOUT".
On /logout click "LOG IN".
Enter the codename noted in 2 and click "CONTINUE".
On /lookup enter a message and click "SUBMIT".
- Verify that the flashed message does not include the "Forgot you codename?" link

Verify link does not show on second login - from /

Access the Source Interface and click "GET STARTED".
Take note of the codename on /generate and click "SUBMIT DOCUMENTS".
On /lookup, click "LOGOUT".
Click on the SecureDrop logo to return to /.
On / click "LOG IN".
Enter the codename noted in 2 and click "CONTINUE".
On /lookup enter a message and click "SUBMIT".
- Verify that the flashed message does not include the "Forgot you codename?" link.

Verify link shows on first login

Access the Source Interface and click "GET STARTED".
Take note of the codename on /generate and click "SUBMIT DOCUMENTS".
On /lookup enter a message and click "SUBMIT".
- Verify that the flashed message includes the "Forgot you codename?" link.

Display the "Forgot you codename?" link to the codename-hint section only on the source's initial login. Ref. freedomofpress#5101

Add functional test to verify the composition of the notification message displayed when a source submits a message.

DrGFreeman · 2021-10-27T01:23:26Z

Moved "Forgot your codename?" text to new line (screenshot below) as per @creviera's suggestion & rebased to develop.

sssoleileraaa

lgtm! i also created a separate but related follow-up issue (needs discussion): #6155

DrGFreeman force-pushed the 5101-submit-codename-link-first-login-only branch from 0cf9432 to 1962bf2 Compare October 15, 2021 03:43

DrGFreeman marked this pull request as ready for review October 15, 2021 03:46

DrGFreeman requested a review from a team as a code owner October 15, 2021 03:46

eloquence added this to Ready for Review in SecureDrop Team Board Oct 15, 2021

DrGFreeman force-pushed the 5101-submit-codename-link-first-login-only branch from 1962bf2 to e54d0c5 Compare October 20, 2021 11:42

conorsch assigned sssoleileraaa Oct 21, 2021

sssoleileraaa reviewed Oct 25, 2021

View reviewed changes

sssoleileraaa previously approved these changes Oct 25, 2021

View reviewed changes

sssoleileraaa moved this from Ready for Review to Under Review in SecureDrop Team Board Oct 25, 2021

DrGFreeman added 3 commits October 26, 2021 21:21

Display codename-hint link only on initial login

3bd24d9

Display the "Forgot you codename?" link to the codename-hint section only on the source's initial login. Ref. freedomofpress#5101

Add functional test to verify submit notifications

b6b3793

Add functional test to verify the composition of the notification message displayed when a source submits a message.

Move "Forgot your codename?" to new line

38016a8

DrGFreeman dismissed sssoleileraaa’s stale review via 38016a8 October 27, 2021 01:21

DrGFreeman force-pushed the 5101-submit-codename-link-first-login-only branch from e54d0c5 to 38016a8 Compare October 27, 2021 01:21

sssoleileraaa approved these changes Oct 27, 2021

View reviewed changes

sssoleileraaa merged commit da2d0b7 into freedomofpress:develop Oct 27, 2021

SecureDrop Team Board automation moved this from Under Review to Done Oct 27, 2021

eaon mentioned this pull request Feb 11, 2022

Release SecureDrop 2.2.0 #6236

Closed

35 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display "Forgot you codename?" codename-hint link only on initial login #6130

Display "Forgot you codename?" codename-hint link only on initial login #6130

DrGFreeman commented Oct 8, 2021 •

edited

Loading

DrGFreeman commented Oct 15, 2021

DrGFreeman commented Oct 20, 2021

conorsch commented Oct 21, 2021

sssoleileraaa Oct 25, 2021

DrGFreeman Oct 26, 2021

sssoleileraaa Oct 26, 2021

sssoleileraaa left a comment

DrGFreeman commented Oct 27, 2021 •

edited

Loading

sssoleileraaa left a comment

Display "Forgot you codename?" codename-hint link only on initial login #6130

Display "Forgot you codename?" codename-hint link only on initial login #6130

Conversation

DrGFreeman commented Oct 8, 2021 • edited Loading

Status

Description of Changes

Testing

Deployment

Checklist

If you made changes to the server application code:

If you made changes to securedrop-admin:

If you made changes to the system configuration:

If you added or removed a file deployed with the application:

If you made non-trivial code changes:

If you added or updated a production code dependency:

DrGFreeman commented Oct 15, 2021

DrGFreeman commented Oct 20, 2021

conorsch commented Oct 21, 2021

sssoleileraaa Oct 25, 2021

Choose a reason for hiding this comment

DrGFreeman Oct 26, 2021

Choose a reason for hiding this comment

sssoleileraaa Oct 26, 2021

Choose a reason for hiding this comment

sssoleileraaa left a comment

Choose a reason for hiding this comment

Testing

DrGFreeman commented Oct 27, 2021 • edited Loading

sssoleileraaa left a comment

Choose a reason for hiding this comment

DrGFreeman commented Oct 8, 2021 •

edited

Loading

If you made changes to `securedrop-admin`:

DrGFreeman commented Oct 27, 2021 •

edited

Loading