-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display "Forgot you codename?" codename-hint link only on initial login #6130
Display "Forgot you codename?" codename-hint link only on initial login #6130
Conversation
0cf9432
to
1962bf2
Compare
Added functional tests, rebased to develop and set status to "Ready for review". |
1962bf2
to
e54d0c5
Compare
Rebased to develop following version 2.1.0 release. |
Hey there, thanks @DrGFreeman! I believe @creviera expressed an interest in reviewing this, so I'm tagging her in here. Likely next week sometime, given our current schedule. |
@@ -1,8 +1,10 @@ | |||
<section class="message"> | |||
<h2>{{ gettext('Success!') }}</h2> | |||
<p>{{ gettext('Thank you for sending this information to us. Please check back later for replies.') }} | |||
{% if new_user_codename %} | |||
<a href="#codename-hint"> | |||
{{ gettext('Forgot your codename?') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] this would look better on a new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected, just one nitpicky comment, so i'll let this sit for a few after approving
Testing
Verify link does not show on second login - from /logout
- Access the Source Interface and click "GET STARTED".
- Take note of the codename on
/generate
and click "SUBMIT DOCUMENTS". - On
/lookup
, click "LOGOUT". - On
/logout
click "LOG IN". - Enter the codename noted in 2 and click "CONTINUE".
- On
/lookup
enter a message and click "SUBMIT".
Verify link does not show on second login - from /
- Access the Source Interface and click "GET STARTED".
- Take note of the codename on
/generate
and click "SUBMIT DOCUMENTS". - On
/lookup
, click "LOGOUT". - Click on the SecureDrop logo to return to
/
. - On
/
click "LOG IN". - Enter the codename noted in 2 and click "CONTINUE".
- On
/lookup
enter a message and click "SUBMIT".
Verify link shows on first login
Display the "Forgot you codename?" link to the codename-hint section only on the source's initial login. Ref. freedomofpress#5101
Add functional test to verify the composition of the notification message displayed when a source submits a message.
e54d0c5
to
38016a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! i also created a separate but related follow-up issue (needs discussion): #6155
Status
Ready for review
Description of Changes
Fixes #5101.
Changes proposed in this pull request:
Display the "Forgot you codename?" link to the
codename-hint
section in the/submit
flashed message only on the source's initial login (i.e. do not display the link after the source logged in using their codename).Add functional test to verify the above behavior. Also include verification of the first submission specific message.
Testing
Verify link does not show on second login - from
/logout
/generate
and click "SUBMIT DOCUMENTS"./lookup
, click "LOGOUT"./logout
click "LOG IN"./lookup
enter a message and click "SUBMIT".Verify link does not show on second login - from
/
/generate
and click "SUBMIT DOCUMENTS"./lookup
, click "LOGOUT"./
./
click "LOG IN"./lookup
enter a message and click "SUBMIT".Verify link shows on first login
/generate
and click "SUBMIT DOCUMENTS"./lookup
enter a message and click "SUBMIT".Deployment
Any special considerations for deployment? Consider both:
N/A.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made changes to
securedrop-admin
:make -C admin test
) pass in the admin development containerIf you made changes to the system configuration:
If you added or removed a file deployed with the application:
If you made non-trivial code changes:
Choose one of the following:
If you added or updated a production code dependency:
Production code dependencies are defined in:
admin/requirements.in
admin/requirements-ansible.in
securedrop/requirements/python3/securedrop-app-code-requirements.in
If you changed another
requirements.in
file that applies only to developmentor testing environments, then no diff review is required, and you can skip
(remove) this section.
Choose one of the following: