ci(slack-fail-post-step): skip notifications from forks #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfm
force-pushed
the
oh-say-can-you-ci
branch
3 times, most recently
from
bb3a58b
to
b8b883f
Compare
Before executing the "slack/notify" step provided by the Slack orb, check that we have a $SLACK_ACCESS_TOKEN from the CircleCI context (reused across projects in our CircleCI organization). Without this check, workflow that expect to send Slack notifications will fail from forks, where CircleCI runs outside our organization and therefore doesn't have access to this context.
cfm
changed the title
eloquence
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #6777 by making the
post-stepsprovided by the Slack orb conditional on having a$SLACK_ACCESS_TOKENfrom the CircleCI environment.Thanks to @nabla-c0d3 (and CircleCI support) for troubleshooting in #6764 (comment).
Testing
freedomofpress/securedrop: https://app.circleci.com/pipelines/github/freedomofpress/securedrop/5664/workflows/760ce89a-bec8-4557-b09a-b5569b814b9ecfm/securedrop: https://app.circleci.com/pipelines/github/freedomofpress/securedrop/5663/workflows/e33fb989-d166-4be9-bbda-a687f937c98cDeployment
CI-only.