Remove obsolete "Extract tor version" ansible tasks #6894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for >= 0.3.4.9 has been obsolete ever since the focal switch, which ships with tor 0.4.2.7. It's not that useful anyways, since apt should pick the higher version regardless. If we really wanted to ensure that our rehosted tor package is installed, we should configure an apt pin. And then dumping to `.tor_version` is presumably unused since we no longer use AWS for SecureDrop testing (related: #6890). In any case, we'd be better served by dumping `apt show tor` or something along those lines.
zenmonkeykstop
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
The check for >= 0.3.4.9 has been obsolete ever since the focal switch, which ships with tor 0.4.2.7. It's not that useful anyways, since apt should pick the higher version regardless. If we really wanted to ensure that our rehosted tor package is installed, we should configure an apt pin.
And then dumping to
.tor_versionis presumably unused since we no longer use AWS for SecureDrop testing (related: #6890). In any case, we'd be better served by dumpingapt show toror something along those lines.Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? Not really.
Checklist