Add tests for empty or malformed recipient gpg key #6912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
reviewed
Aug 3, 2023
There was a problem hiding this comment.
Awesome! Tests and errors look good. Since most of the code is identical across the tree tests, do you want to consolidate it into one test function that iterates over the 3 cases? There's no fancy parameterization in Rust like pytest has so it'd just be iterating over a vec.
rocodes
force-pushed
the
6889-add-redwood-test
branch
2 times, most recently
from
a940926
to
6417c18
Compare
rocodes
commented
Aug 8, 2023
rocodes
force-pushed
the
6889-add-redwood-test
branch
from
6417c18
to
2304674
Compare
legoktm
previously approved these changes
Aug 8, 2023
rocodes
force-pushed
the
6889-add-redwood-test
branch
from
2304674
to
473d558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #6889.
Changes proposed in this pull request:
Add tests for cases of missing or malformed journalist key
Visual review/CI passes
Deployment
n/a
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development container (make rust-lint,make rust-test)If you made non-trivial code changes:
Choose one of the following: