Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: print current Git ref at the top of the build transcript #7019

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

cfm
Copy link
Member

@cfm cfm commented Oct 20, 2023

Status

Ready for review

Description of Changes

Closes #6792 by prefacing the script transcript logged by make-build-debs.sh with the output of git log -1 --oneline, e.g.:

user@sd-dev:~/securedrop$ head build/20231019-securedrop.log
Script started on 2023-10-19 18:19:19-07:00 [TERM="xterm-256color" TTY="/dev/pts/4" COLUMNS="104" LINES="54"]
+ git log -1 --oneline
53f8dea23 (HEAD -> 6792-print-git-ref, origin/develop, origin/HEAD, develop) gpg: Signature made Thu 19 Oct 2023 01:24:00 PM PDT
gpg:                using RSA key 4AEE18F83AFDEB23
gpg: Can't check signature: No public key
Merge pull request #6830 from freedomofpress/ansible-major-bump
++ pwd
+ OCI_RUN_ARGUMENTS='--user=root -v /home/user/securedrop:/src:Z'
+ which podman
+ OCI_BIN=podman

Testing

  • Visual review.

Deployment

Tooling-only; no deployment considerations. May be worth backporting into release/2.7.0 to increase the usefulness of our build logs.

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super simple and works as expected, except it's outputting color codes :( Suggestion to fix that inline!

builder/build-debs.sh Outdated Show resolved Hide resolved
@legoktm legoktm self-assigned this Oct 23, 2023
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :)

@legoktm legoktm merged commit 3a665de into develop Oct 26, 2023
12 checks passed
@legoktm legoktm deleted the 6792-print-git-ref branch October 26, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

make build-debs.sh Git-aware
2 participants