Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Git needs --no-pager under non-interactive SSH #7038

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

cfm
Copy link
Member

@cfm cfm commented Oct 27, 2023

Status

Ready for review

Description of Changes

Fixes https://app.circleci.com/pipelines/github/freedomofpress/securedrop/6577/workflows/d569397a-d36b-42de-8532-3439a2889d25/jobs/73991?invite=true#step-104-720_41, in which SSH from CircleCI stalls on WARNING: terminal is not fully functional.

Testing

  • staging-test-with-rebase passes.

Deployment

  • Backport into release/2.7.0.

@cfm cfm added this to the SecureDrop 2.7.0 milestone Oct 27, 2023
@cfm cfm requested a review from a team as a code owner October 27, 2023 01:07
Otherwise staging-test-with-rebase's SSH from CircleCI stalls on
"WARNING: terminal is not fully functional".
@cfm cfm changed the title fix: run git log under TERM=dumb fix: Git needs --no-pager under non-interactive SSH Oct 27, 2023
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenmonkeykstop zenmonkeykstop merged commit c802f74 into develop Oct 27, 2023
13 checks passed
@legoktm legoktm deleted the stg-strikes-again branch October 27, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants