Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustix from 0.38.18 to 0.38.21 #7114

Merged
merged 3 commits into from Feb 15, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2024

Bumps rustix from 0.38.18 to 0.38.21.

Commits
  • cf2ad7f chore: Release rustix version 0.38.21
  • 4186613 Miscellaneous documentation cleanups.
  • bde49f1 Adjust sockaddr lengths for illumos in more more place. (#904)
  • b0a83ce Add connect_unspec (#903)
  • b01b482 Fix getsockopt zeroing memory (#901)
  • 36e3999 Fix a test failures on illumos. (#900)
  • 1ab21e6 Fix p{read,write}v{,v2}'s encoding of the offset argument on Linux. (#896)
  • 0b7ccf4 Miscellaneous documentation cleanups. (#894)
  • 3f338d8 Fix miscellaneous clippy lints. (#893)
  • e2314b7 Fix renameat_with with flags on Android. (#892)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [rustix](https://github.com/bytecodealliance/rustix) from 0.38.18 to 0.38.21.
- [Release notes](https://github.com/bytecodealliance/rustix/releases)
- [Commits](bytecodealliance/rustix@v0.38.18...v0.38.21)

---
updated-dependencies:
- dependency-name: rustix
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner February 14, 2024 18:27
@dependabot dependabot bot added dependencies Pull requests that update a dependency file Rust Issues that touch Rust code labels Feb 14, 2024
Release was made by a trusted author.
@legoktm
Copy link
Member

legoktm commented Feb 15, 2024

Analyzing GHSA-c827-hfw6-qwvm, I traced our usage of rustix to two crates (via cargo tree -i -p rustix --target all):

  • lalrpop through is-terminal: this usage was actually removed in lalrpop 0.20.1 but that release was yanked for other issues. In any case, the is-terminal usage is for error handling and more importantly, doesn't use this function.
    • But! is-terminal has been merged into Rust itself and if we upgrade it, it'll use the libc implementation instead of rustix, so let's do that.
  • tempfile (dev dep), just uses other file options and not the vulnerable rustix::fs::Dir iterator.

So we're not vulnerable for this function, and we'll remove rustix from our shipped build altogether.

This switches the underlying implementation to use the libc crate
instead of rustix, which ends up removing the rustix dependency entirely
(outside of dev deps).

Also is-terminal has been merged into Rust itself and will go away
whenever there's a new lalrpop release we can update to.
@legoktm
Copy link
Member

legoktm commented Feb 15, 2024

(tagging for review from someone else now that I've made non-trivial changes)

@cfm cfm self-assigned this Feb 15, 2024
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this more closely, @legoktm.

@cfm cfm merged commit bbf1434 into develop Feb 15, 2024
17 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/rustix-0.38.21 branch February 15, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Rust Issues that touch Rust code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants