Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sequoia-openpgp to 1.20.0 #7178

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Bump sequoia-openpgp to 1.20.0 #7178

merged 1 commit into from
Jun 13, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jun 12, 2024

Status

Ready for review

Description of Changes

See https://gitlab.com/sequoia-pgp/sequoia/-/blob/openpgp/v1.20.0/openpgp/NEWS?ref_type=tags for a list of changes, none of which should require changes on our end.

Fixes #7177.

Testing

How should the reviewer test this PR?

  • CI passes

Deployment

Any special considerations for deployment? n/a, applies equally to both

Checklist

  • Linting (make lint) and tests (make test) pass in the development container

@legoktm legoktm requested a review from a team as a code owner June 12, 2024 19:46
@legoktm
Copy link
Member Author

legoktm commented Jun 12, 2024

CI needs #7179 to be happy.

zenmonkeykstop
zenmonkeykstop previously approved these changes Jun 13, 2024
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is good, LGTM

@legoktm legoktm dismissed zenmonkeykstop’s stale review June 13, 2024 17:07

The merge-base changed after approval.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is good, LGTM

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more time with feeling

zenmonkeykstop
zenmonkeykstop previously approved these changes Jun 13, 2024
@legoktm legoktm dismissed zenmonkeykstop’s stale review June 13, 2024 17:12

The merge-base changed after approval.

@legoktm legoktm closed this Jun 13, 2024
@legoktm legoktm reopened this Jun 13, 2024
See <https://gitlab.com/sequoia-pgp/sequoia/-/blob/openpgp/v1.20.0/openpgp/NEWS?ref_type=tags>
for a list of changes, none of which should require changes on our end.

Fixes #7177.
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenmonkeykstop zenmonkeykstop merged commit 5733557 into develop Jun 13, 2024
17 checks passed
@legoktm legoktm deleted the sequoia-bump branch June 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade sequoia-openpgp to latest (1.20.0)
2 participants