Skip to content
This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

Icons do not work in Linux #19

Closed
conorsch opened this issue May 8, 2017 · 7 comments · Fixed by #28
Closed

Icons do not work in Linux #19

conorsch opened this issue May 8, 2017 · 7 comments · Fixed by #28

Comments

@conorsch
Copy link
Contributor

conorsch commented May 8, 2017

The interface icons for common actions such as Save and Copy do not render on Debian Stretch. Example:

sunder-linux-no-icons

On Mac those icons render just fine. Tried installing the deb package on Tails, to make sure the problem wasn't with my workstation (which is running Debian Stretch), but the install failed. See gist here: https://gist.github.com/conorsch/1499ec7eb575258ebcadda1595ed4f78

Looks like we'll need a lot more Linux testing now that we've switched the build logic to electron-builder. Happy to handle that, but waiting for resolution of #16 and #17 first.

@GabeIsman
Copy link
Contributor

Hmm, this looks like the icon just isn't getting loaded. Perhaps an unsupported font format? I'll see if I can spin up a linux dev box and take a look.

@GabeIsman
Copy link
Contributor

Having problems getting a working linux environment, packing it in for the night.

@GabeIsman
Copy link
Contributor

This is still an issue. The app is requesting fonts from /vagrant/assets/something, which makes me think there's a webpack misconfiguration that shows up in the slightly different vagrant environment. I'll see if I can identify the issue.

@conorsch
Copy link
Contributor Author

conorsch commented Jun 9, 2017

How'd you find that info? Still learning the basics about debugging Electron apps, so any breadcrumbs you want to sprinkle behind you would be quite welcome.

@GabeIsman
Copy link
Contributor

I applied the patch in ad68c72, which enables electron-debug in production, then rebuilt the app. When you launch the application, a debug console will open, allowing you to see errors, inspect resources, etc. Extremely handy. We really ought to turn this into a flag on the dist command or something. I've used it a lot over the last couple days.

@GabeIsman
Copy link
Contributor

I've also been keeping the build-testing branch around (which has that commit) for merging into test branches.

@conorsch
Copy link
Contributor Author

conorsch commented Jun 9, 2017

Will use that build-tesing branch more in the future, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants