Visual update #17
Visual update #17
Conversation
|
Problems from #16 persist, even on Mac; specifically:
That said, the new assets did indeed land and render well on Mac. (Thus the test failures probably came in through #16, not #17.) Check it out:
Unfortunately clicking on Create Secret Shares on that screen doesn't do anything, save render the sweet new animation of the Sunder logo rotating. In the interest of transparency, I used this branch to combine changes from #16 and #17 and rebase them on top of the latest master: https://github.com/freedomofpress/sunder/tree/testing-branch-integrate-prs-16-and-17 but that probably won't be useful to @GabeIsman. Over to you for re-review, Gabe—I recommend starting with #16. |
|
Sounds like the same problem as in #16. |
|
Resolved build snags in #17 with help from @GabeIsman. Since this PR targets that one, I'm going to merge here and reevaluate over there. Will certainly need a rebase to get #16 into master, but fortunately this merges cleanly into #16. |
|
@conorsch It seems like something went weird with the merge of this branch. Since the PR is closed, I would expect to see these changes on master, but they are not there. It seems that Gabe's original intention was for us to merge the |
|
@garrettr It's worse than simply the commits not making it into master, I think only some did. Working on a resolution now, and will open a PR shortly once all the tests pass and I have working builds on both Mac and Linux. |
The `icns2png` command was referencing the old path to the `app.icns` file, which is no longer valid as of #17 and #24. Fixing that command allows the icns -> png format conversion work as intended. No changes required to `package.json`, since the paths there are already correct. Closes #23. Signed-off-by: Conor Schaefer <conor@freedom.press>
This integrates the design assets from Sina and updates the colors to match his scheme. This doesn't yet implement all the changes called for by the limited mocks that I've seen, but it definitely makes the app feel a lot like the mocks.
I may stop short of really putting on all the polish that Sina called for. I don't think custom number inputs, for example, should be blocking launch. These things can easily be addressed down the road/by community contributors.
Certain things also aren't quite right still, given the limited nature of the mocks. For example, I didn't get red in the desired palette for error states, so the red looks a little off. I'm also not really sure what to do about the puzzle icons used in the recovery flow. We need 'shard' icon. Or we could just lose the icons there entirely and just checkmarks or some such.