Skip to content
This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

Update dependencies #15

Merged
merged 18 commits into from
May 5, 2017
Merged

Update dependencies #15

merged 18 commits into from
May 5, 2017

Conversation

GabeIsman
Copy link
Contributor

Lots of package updates and reconfigurations/refactorings to match new APIs. There's probably more work to be done in this arena (it never ends!), but there are now very few deprecation warnings and the build process is working smoothly on OS X.

The project is undergoing a total rewrite for 4.x,
but at least for now the plan is to support 3.x
indefinitely. Migrating to 4.x will require
rewriting the routing code (there isn't much of it.)
This was more trouble than it's worth. It wasn't actually catching
problematic situations.

This also fixes all remaining deprecation warnings!
This was referenced Apr 30, 2017
@conorsch
Copy link
Contributor

conorsch commented May 5, 2017

Reviewing now! Will try to get builds working again locally.

@conorsch
Copy link
Contributor

conorsch commented May 5, 2017

Had some trouble building the deb packages; needed to update the Ansible config to install newer versions of nodejs. Also tracked down an icon error:

Building AppImage for arch x64
Error: linux.icon must be set to an icon set directory, but /vagrant/build/icons/app.icns is not a directory. Please see https://github.com/electron-userland/electron-builder/wiki/Options#LinuxBuildOptions-icon
at /vagrant/node_modules/electron-builder/src/targets/LinuxTargetHelper.ts:39:17
at Generator.throw ()
at runCallback (timers.js:672:20)
at tryOnImmediate (timers.js:645:5)
at processImmediate [as _immediateCallback] (timers.js:617:5)

Needed to install some additional apt packages, and generate the PNG-format icons. Will add that to the Ansible playbook and push up here.

Oddly it appears that the build process no longer outputs a deb package; rather, I just get a binary and helper files extracted to dist/linux-unpacked/. Will hit the docs for the electron-builder project, but looks like we may need to add back in some wrapper logic to generate the deb package to contain the built files. I'm fine with punting that to a separate issue if so.

Conor Schaefer added 7 commits May 5, 2017 16:26
Building under Linux via vagrant-libvirt these days. Activates NFS
for shared directory (with two-way sync support).
Laughable, I know, but even a gig of RAM is insufficient to build the
app now. Bumped to 2GB and no out-of-memory errors yet.
Using a play-level var to override the role default (which is 6.x).
When building the Linux package, we need some additional apt packages,
as documented here:

  https://github.com/electron-userland/electron-builder/wiki/Multi-Platform-Build#linux

We'll also need to generate the PNG-format icons in the Ansible config.
The electron-builder documentation states that we must use `icns2png` to
extract the macOS icon format into PNGs, for use in the Linux version of
the application. Added that command to the Ansible build logic, and also
updated the Makefile and gitignore file to recognize these files.
The ansible-galaxy install action is not idempotent, so it's possible
that folks will have extremely old versions of the dependency roles
lying around. Let's use the `make clean-build` action to clear out these
old roles and default to the latest from upstream.
@conorsch
Copy link
Contributor

conorsch commented May 5, 2017

Oddly it appears that the build process no longer outputs a deb package

Resolved via the target build option for Linux, documented here: https://github.com/electron-userland/electron-builder/wiki/Options#linuxbuildoptions--commonlinuxoptions

I'm now able to manually install the deb package build from the repo. LGTM! 😎

@conorsch conorsch merged commit e76d232 into master May 5, 2017
@conorsch conorsch mentioned this pull request May 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants