-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
The project is undergoing a total rewrite for 4.x, but at least for now the plan is to support 3.x indefinitely. Migrating to 4.x will require rewriting the routing code (there isn't much of it.)
This was more trouble than it's worth. It wasn't actually catching problematic situations. This also fixes all remaining deprecation warnings!
Reviewing now! Will try to get builds working again locally. |
Had some trouble building the deb packages; needed to update the Ansible config to install newer versions of nodejs. Also tracked down an icon error:
Needed to install some additional apt packages, and generate the PNG-format icons. Will add that to the Ansible playbook and push up here. Oddly it appears that the build process no longer outputs a deb package; rather, I just get a binary and helper files extracted to |
Building under Linux via vagrant-libvirt these days. Activates NFS for shared directory (with two-way sync support).
Laughable, I know, but even a gig of RAM is insufficient to build the app now. Bumped to 2GB and no out-of-memory errors yet.
Using a play-level var to override the role default (which is 6.x).
When building the Linux package, we need some additional apt packages, as documented here: https://github.com/electron-userland/electron-builder/wiki/Multi-Platform-Build#linux We'll also need to generate the PNG-format icons in the Ansible config.
The electron-builder documentation states that we must use `icns2png` to extract the macOS icon format into PNGs, for use in the Linux version of the application. Added that command to the Ansible build logic, and also updated the Makefile and gitignore file to recognize these files.
The ansible-galaxy install action is not idempotent, so it's possible that folks will have extremely old versions of the dependency roles lying around. Let's use the `make clean-build` action to clear out these old roles and default to the latest from upstream.
Resolved via the I'm now able to manually install the deb package build from the repo. LGTM! 😎 |
Lots of package updates and reconfigurations/refactorings to match new APIs. There's probably more work to be done in this arena (it never ends!), but there are now very few deprecation warnings and the build process is working smoothly on OS X.