This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Quickfix: select copyEl before copying text #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quickfix for #29. I'm fine with merging this for now, but also think the technique of adding the share text as a hidden input element and using
document.execCommand('copy')
is a bit of a hack, and there might be a cleaner way to do this using Electron's Clipboard API.@GabeIsman Did you try using Electron's Clipboard API at any point while implementing this feature? Wondering if there's some reason why it wouldn't work (obviously I am fairly novice when it comes to both Electron and React).