-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General code gardening #270
Comments
@p3trur0 I agree. We should review the code, remove unnecessary comments and create new issues from "TODO" ones. Also please consider https://sonarcloud.io/dashboard?id=com.freedomotic%3Afreedomotic |
@mcicolella cool, I think that's important to have a cleaner source code. |
@p3trur0 of course! Your support is very precious! |
@p3trur0 For "Define and throw a dedicated exception instead of using a generic one" (RuntimeExceptions) issues reported by Sonarcloud can we use FreedomoticRuntimeException in any case for now? |
@mcicolella yes indeed. You can consider |
Hi there,
navigating in the source code I see a lot of commented lines. Is it worth to clean it a little by removing unnecessary commented lines?
The main advantage of this cleaning is to make the code easier to read, then more elegant and appealing for further contributors.
Opinions anyone?
The text was updated successfully, but these errors were encountered: