Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code gardening #270

Open
ubaldop opened this issue Jun 29, 2017 · 5 comments
Open

General code gardening #270

ubaldop opened this issue Jun 29, 2017 · 5 comments

Comments

@ubaldop
Copy link
Contributor

ubaldop commented Jun 29, 2017

Hi there,

navigating in the source code I see a lot of commented lines. Is it worth to clean it a little by removing unnecessary commented lines?

The main advantage of this cleaning is to make the code easier to read, then more elegant and appealing for further contributors.

Opinions anyone?

@mcicolella
Copy link
Collaborator

@p3trur0 I agree. We should review the code, remove unnecessary comments and create new issues from "TODO" ones. Also please consider https://sonarcloud.io/dashboard?id=com.freedomotic%3Afreedomotic

@ubaldop
Copy link
Contributor Author

ubaldop commented Jun 30, 2017

@mcicolella cool, I think that's important to have a cleaner source code.
May I take a look at this too?

@mcicolella
Copy link
Collaborator

@p3trur0 of course! Your support is very precious!

@mcicolella
Copy link
Collaborator

@p3trur0 For "Define and throw a dedicated exception instead of using a generic one" (RuntimeExceptions) issues reported by Sonarcloud can we use FreedomoticRuntimeException in any case for now?

@ubaldop
Copy link
Contributor Author

ubaldop commented Sep 30, 2017

@mcicolella yes indeed. You can consider FreedomoticRuntimeException as the root of the unchecked exceptions of Freedomotic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants