Fix and enable -fvisibility=hidden by default when building with gcc #68
Conversation
FGAPI used to be defined to an empty body on non-windows platforms. Provide a proper definition for gcc to fix build with gcc -fvisibility=hidden. Add FGAPI attribute to definitions of glutStroke* and glutBitmap* variables, to make them exported when gcc -fvisibility=hidden is in effect.
This effectively unexports the following 168 internal symbols: B fgDisplay B fgJoystick B fgStructure B fghBindBuffer B fghBufferData B fghDeleteBuffers B fghDisableVertexAttribArray B fghEnableVertexAttribArray B fghGenBuffers B fghVertexAttribPointer B sball_initialized D fgFontFixed8x13 D fgFontFixed9x15 D fgFontHelvetica10 D fgFontHelvetica12 D fgFontHelvetica18 D fgFontTimesRoman10 D fgFontTimesRoman24 D fgState D fgStrokeMonoRoman D fgStrokeRoman D xi_opcode T XParseGeometry T fgAddToWindowDestroyList T fgCheckActiveMenu T fgCloseWindow T fgCloseWindows T fgCreateMenu T fgCreateStructure T fgCreateWindow T fgDeactivateMenu T fgDeinitialize T fgDestroyMenu T fgDestroyStructure T fgDestroyWindow T fgDisplayMenu T fgElapsedTime T fgEnumMenus T fgEnumSubWindows T fgEnumWindows T fgError T fgGetActiveMenu T fgHandleExtensionEvents T fgHasSpaceball T fgHintPresent T fgInitGL2 T fgInitialiseInputDevices T fgInitialiseJoysticks T fgInitialiseSpaceball T fgInputDeviceClose T fgInputDeviceDetect T fgIsSpaceballXEvent T fgJoystickClose T fgJoystickDetect T fgJoystickPollWindow T fgListAppend T fgListInit T fgListInsert T fgListLength T fgListRemove T fgMenuByID T fgOpenWindow T fgPlatformChangeDisplayMode T fgPlatformCloseDisplay T fgPlatformCloseWindow T fgPlatformCreateWindow T fgPlatformDeinitialiseInputDevices T fgPlatformDestroyContext T fgPlatformEnterGameMode T fgPlatformFullScreenToggle T fgPlatformGetConfig T fgPlatformGetGLUTProcAddress T fgPlatformGetGameModeVMaxExtent T fgPlatformGetModifiers T fgPlatformGetProcAddress T fgPlatformGlutDeviceGet T fgPlatformGlutGet T fgPlatformGlutGetModeValues T fgPlatformGlutSetIconTitle T fgPlatformGlutSetWindowTitle T fgPlatformGlutSwapBuffers T fgPlatformHasSpaceball T fgPlatformHideWindow T fgPlatformIconifyWindow T fgPlatformInitWork T fgPlatformInitialize T fgPlatformInitializeSpaceball T fgPlatformJoystickClose T fgPlatformJoystickInit T fgPlatformJoystickOpen T fgPlatformJoystickRawRead T fgPlatformLeaveGameMode T fgPlatformMainLoopPreliminaryWork T fgPlatformOpenWindow T fgPlatformPopWindow T fgPlatformPosResZordWork T fgPlatformPositionWindow T fgPlatformProcessSingleEvent T fgPlatformPushWindow T fgPlatformRegisterDialDevice T fgPlatformRememberState T fgPlatformReshapeWindow T fgPlatformRestoreState T fgPlatformSetCursor T fgPlatformSetWindow T fgPlatformShowWindow T fgPlatformSleepForEvents T fgPlatformSpaceballClose T fgPlatformSpaceballNumButtons T fgPlatformSpaceballSetWindow T fgPlatformSystemTime T fgPlatformVisibilityWork T fgPlatformWarpPointer T fgPrintXIDeviceEvent T fgPrintXILeaveEvent T fgProcessWork T fgRegisterDevices T fgSetCursor T fgSetWindow T fgSpaceballClose T fgSpaceballHandleXEvent T fgSpaceballNumButtons T fgSpaceballSetWindow T fgSystemTime T fgUpdateMenuHighlight T fgWarning T fgWindowByHandle T fgWindowByID T fghCalculateMenuBoxSize T fghChooseConfig T fghCloseInputDevices T fghContextCreationError T fghCreateNewContext T fghDefaultReshape T fghDrawGeometrySolid T fghDrawGeometryWire T fghFontByID T fghGenerateCone T fghGenerateCylinder T fghGenerateTorus T fghIsLegacyContextRequested T fghMapBit T fghNumberOfAuxBuffersRequested T fghOnPositionNotify T fghOnReshapeNotify T fghParseCommandLineArguments T fghPlatformGetCursorPos T fghPlatformGlutGetGLX T fghRedrawWindow T fghRedrawWindowAndChildren T glutJoystickGetCenter T glutJoystickGetDeadBand T glutJoystickGetMaxRange T glutJoystickGetMinRange T glutJoystickGetNumAxes T glutJoystickGetNumButtons T glutJoystickGetSaturation T glutJoystickNotWorking T glutJoystickSetCenter T glutJoystickSetDeadBand T glutJoystickSetMaxRange T glutJoystickSetMinRange T glutJoystickSetSaturation T serial_close T serial_flush T serial_getchar T serial_open T serial_putchar
|
So the one question I see is that you mark the font definitions in X11 l with FGAPI which, if I understand, will not be exported in the shared library. So how would a program link against them with GCC using X11? |
|
I also just realized, you only do this for GCC. Is it not possible for Clang or whatever non-Windows compiler is used? |
|
Just the otherwise, I mark these font variables with FGAPI to make them exported. |
|
This should be possible for clang and maybe other compilers. |
|
@jtsiomb, should this be merged? |
|
I don't see any harm in hiding any symbols which aren't part of the API. The only potential issue, is breaking programs which use some internal freeglut symbol to augment the functionality. For example using, Also in the list of symbols that will become unaccessible with this patch, I see a bunch of glut-prefixed joystick functions. I assume these should have the FGAPI prefix too. |
|
Ok, shall i merge and add FGAPI to fgDisplay? |
|
On Mon, Sep 02, 2019 at 10:27:01PM -0700, Diederick C. Niehorster wrote:
Ok, shall i merge and add FGAPI to fgDisplay?
The patch has been tested in Sisyphus which means that fgDisplay is not needed to be exported in GNU/Linux.
I don't mind if FGAPI is added to fgDisplay if you suppose it might be needed elsewhere.
|
Yes, I'd say let's play it safe and add FGAPI to fgDisplay, and also to the joystick functions which for some reason don't already have it. Otherwise I'm fine with merging this. |
|
I see this was never merged. But I'm also having second thoughts about whether this should be merged. I'm slightly nervous about having the public I'm also not sure if the |
|
For the visibility thing, using __has_attribute is probably the right approach. |
This short series fixes build with gcc -fvisibility=hidden, and enables -fvisibility=hidden by default when building with gcc. As result, 168 internal symbols are no longer exported by the shared library.