Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipauser: Better description of UID and GID parameters #1045

Merged
merged 1 commit into from
Mar 20, 2023
Merged

ipauser: Better description of UID and GID parameters #1045

merged 1 commit into from
Mar 20, 2023

Conversation

rjeffman
Copy link
Member

This patch provides better text for the description of UID and GID parameters.

@rjeffman
ipauser: Better description of UID and GID parameters
691fbd0 
This patch provides better text for the description of UID and GID
parameters.
t-woerner
t-woerner approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@t-woerner t-woerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

varunmylaraiah
varunmylaraiah approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@varunmylaraiah varunmylaraiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeffman
Copy link
Member Author

rjeffman commented Mar 8, 2023

@t-woerner and @varunmylaraiah, it looks like GID is also always attributed when not provided.
As this is true for several fields in IPA, what do you think about removing " (system will assign one if not provided)" from the UID field and modifying the commit message to something like "Make UID and GID description closer to CLI" ?

(I'm fine merging this as it is, using the same text as CLI.)

@t-woerner t-woerner merged commit cf27a98 into freeipa:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunmylaraiah varunmylaraiah varunmylaraiah approved these changes

@t-woerner t-woerner t-woerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rjeffman @varunmylaraiah @t-woerner