Fix ansible-lint on tests #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
fix_ansible_lint_tests
branch
from
a361d59
to
7339f8d
Compare
t-woerner
reviewed
Feb 21, 2023
tests/user/users.json
Outdated
| @@ -0,0 +1,3504 @@ | |||
| { | |||
There was a problem hiding this comment.
This is created within the test. What about having only "{}" as content?
There was a problem hiding this comment.
But the pre-generated file will stop create_users_json.yml from creating the proper file with valid expiration dates.
Should the file still be missing instead?
There was a problem hiding this comment.
This is a mistake on my side. This file should not make into the patch.
There was a problem hiding this comment.
Fixed now. I removed the file.
|
It would be good to have the pre-commit changes in a separate PR. They are not really related to ansible-lint. |
ansible-lint is issuing an warning when using '# noqa 505' instead of '#noqa missing-import' on playbooks. This patch changes all occurrences of the tag to use the newer format.
In latest ansible-lint versions, the use of "blocks" has a required order to be implemented. According to ansible-lint error mesage, the order is name, when, block, rescue, always. As not following this rule is now an error, this patch fixes all tests for the 'key-order[task]' error.
A dangling 'when:' clause was failing anisble-lint tests as the task did not match any valid schema. The dangling clause was removed, and the usage of 'shell' was changed from free form to use the 'cmd' parameter.
rjeffman
force-pushed
the
fix_ansible_lint_tests
branch
from
7339f8d
to
16ce5f2
Compare
|
pre-commit commit moved to #1049. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent PR checks are failing due to
ansible-lintbeing more strict and complaining about errors it didn't before.With this PR, the errors are fixed and pre-commit is updated to match the upstream tool versions, so verification can be done, also, on commit time, before opening a PR.