Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EXAMPLE sections for multiuser and multihost handling. #1047

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

dkarpele
Copy link
Collaborator

@dkarpele dkarpele commented Feb 20, 2023

Solves #1040

@dkarpele dkarpele self-assigned this Feb 20, 2023
@dkarpele dkarpele requested review from rjeffman, frasertweedale and t-woerner and removed request for frasertweedale February 21, 2023 20:48
@@ -573,6 +584,14 @@
name: pinky,brain
state: enabled

# Remove but preserve user pinky
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove several users without resorting to users simply by adding multiple names. In my opinion, that's a more readable way to do this.

@t-woerner what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. It is working both ways, though. Therefore it might be good to have both examples.

Signed-off-by: Denis Karpelevich <dkarpele@redhat.com>
Copy link
Member

@rjeffman rjeffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@t-woerner t-woerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-woerner t-woerner merged commit 183ea7f into freeipa:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants