Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roles/ipaserver: Allow deployments with random serial numbers #1060

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

rjeffman
Copy link
Member

Since FreeIPA version 4.10 it is possible to deploy servers that use Random Serial Number v3 support for certificates.

This patch exposes the 'random_serial_numbers' parameter, as 'ipaserver_random_serial_numbers', allowing a user to have random serial numbers enabled for the domain.

The use of random serial numbers is allowed on new installations only.

@rjeffman rjeffman requested a review from t-woerner March 16, 2023 15:51
@rjeffman rjeffman force-pushed the ipaserver_random_serial_numbers branch from 98953a9 to 2b30ecf Compare March 20, 2023 15:14
@varunmylaraiah
Copy link
Collaborator

Thanks for the PR.

Copy link
Collaborator

@varunmylaraiah varunmylaraiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Downstream tests work fine with this PR.

@t-woerner
Copy link
Member

It might be good to add ipaserver_random_serial_numbers: false to ipaserver/defaults/main.yml.

@varunmylaraiah
Copy link
Collaborator

varunmylaraiah commented Mar 30, 2023

@t-woerner changes work fine with setup_ca

[root@master ~]# ipa cert-find
-----------------------
13 certificates matched
-----------------------
  Issuing CA: ipa
  Subject: CN=Certificate Authority,O=<xxxxxxxxxxx>
  Issuer: CN=Certificate Authority,O=<xxxxxxxxxxx>
  Not Before: Thu Mar 30 08:09:52 2023 UTC
  Not After: Mon Mar 30 08:09:52 2043 UTC
  Serial number: 7351865533529336604938147811995291205
  Serial number (hex): 0x587EAF4CC2849CC609DA283BA0E45
  Status: VALID
  Revoked: False

@rjeffman rjeffman force-pushed the ipaserver_random_serial_numbers branch 2 times, most recently from 4f3da2b to 8deae11 Compare March 30, 2023 19:33
roles/ipaserver/README.md Outdated Show resolved Hide resolved
@rjeffman rjeffman force-pushed the ipaserver_random_serial_numbers branch from 8deae11 to ca352d0 Compare April 4, 2023 12:30
Since FreeIPA version 4.10 it is possible to deploy servers that use
Random Serial Number v3 support for certificates.

This patch exposes the 'random_serial_numbers' parameter, as
'ipaserver_random_serial_numbers', allowing a user to have random serial
numbers enabled for the domain.

The use of random serial numbers is allowed on new installations only.
@rjeffman rjeffman force-pushed the ipaserver_random_serial_numbers branch from ca352d0 to a4087a7 Compare April 4, 2023 13:38
@t-woerner t-woerner merged commit ecab42b into freeipa:master Apr 4, 2023
31 checks passed
@t-woerner
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants