-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roles/ipaserver: Allow deployments with random serial numbers #1060
Merged
t-woerner
merged 1 commit into
freeipa:master
from
rjeffman:ipaserver_random_serial_numbers
Apr 4, 2023
Merged
roles/ipaserver: Allow deployments with random serial numbers #1060
t-woerner
merged 1 commit into
freeipa:master
from
rjeffman:ipaserver_random_serial_numbers
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-woerner
reviewed
Mar 20, 2023
rjeffman
force-pushed
the
ipaserver_random_serial_numbers
branch
from
March 20, 2023 15:14
98953a9
to
2b30ecf
Compare
Thanks for the PR. |
varunmylaraiah
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Downstream tests work fine with this PR.
It might be good to add |
@t-woerner changes work fine with setup_ca
|
rjeffman
force-pushed
the
ipaserver_random_serial_numbers
branch
2 times, most recently
from
March 30, 2023 19:33
4f3da2b
to
8deae11
Compare
t-woerner
reviewed
Apr 4, 2023
rjeffman
force-pushed
the
ipaserver_random_serial_numbers
branch
from
April 4, 2023 12:30
8deae11
to
ca352d0
Compare
Since FreeIPA version 4.10 it is possible to deploy servers that use Random Serial Number v3 support for certificates. This patch exposes the 'random_serial_numbers' parameter, as 'ipaserver_random_serial_numbers', allowing a user to have random serial numbers enabled for the domain. The use of random serial numbers is allowed on new installations only.
rjeffman
force-pushed
the
ipaserver_random_serial_numbers
branch
from
April 4, 2023 13:38
ca352d0
to
a4087a7
Compare
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since FreeIPA version 4.10 it is possible to deploy servers that use Random Serial Number v3 support for certificates.
This patch exposes the 'random_serial_numbers' parameter, as 'ipaserver_random_serial_numbers', allowing a user to have random serial numbers enabled for the domain.
The use of random serial numbers is allowed on new installations only.