Add support for managing idoverrideusers in ipagroup. #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Correct me if this is wrong, but from what I can tell there's no way to add ID overrides entries using Ansible anyway? |
|
@DazAh no, until this PR is merged. |
Just to be clear from what I can tell your PR only includes adding a pre existing id user override to a group. Pretty sure adding a user override in the first place is missing which is unfortunate. |
rjeffman
force-pushed
the
ipagroup_add_idoverrideuser
branch
3 times, most recently
from
34ed2ea
to
99693ca
Compare
rjeffman
force-pushed
the
ipagroup_add_idoverrideuser
branch
from
99693ca
to
a27e53f
Compare
rjeffman
force-pushed
the
ipagroup_add_idoverrideuser
branch
from
a27e53f
to
17a20ba
Compare
t-woerner
reviewed
Jul 22, 2021
t-woerner
reviewed
Jul 22, 2021
rjeffman
changed the title
rjeffman
force-pushed
the
ipagroup_add_idoverrideuser
branch
3 times, most recently
from
da2e1d8
to
09172cc
Compare
rjeffman
changed the title
rjeffman
force-pushed
the
ipagroup_add_idoverrideuser
branch
from
09172cc
to
cdcd713
Compare
|
"group_add_member: group1: Unknown option: idoverrideuser" - The option was added with IPA 4.9.0. |
rjeffman
force-pushed
the
ipagroup_add_idoverrideuser
branch
from
cdcd713
to
af056ed
Compare
|
@t-woerner actually, the changes go back to IPA 4.8.7. I updated the code and tests to reflect this. |
The group CLI option `idoverrideusers` was not supported by
ansible-freeipa, and this patch adds support to it.
Tests require an AD trust, and a user `aduser@ad.ipa.test` to exist, or
the user name must be provided (variable, CLI) through `test_ad_user`.
A new test playbook was added:
tests/group/test_group_idoverrideuser.yml
rjeffman
force-pushed
the
ipagroup_add_idoverrideuser
branch
from
af056ed
to
099eb96
Compare
varunmylaraiah
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI option
idoverrideuserswas not supported by ansible-freeipa,and this patch adds support to it.
Tests require an AD trust, and a usere
aduser@ad.ipa.testto exist.A new test was added: