ipadnszone: add check mode support #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
dnszone_add_check_mode_support
branch
2 times, most recently
from
79e2d3f
to
7de95aa
Compare
All ansible-freeipa modules should support 'check_mode: yes', but the support for creating modules with this was absent in the base class. This patch adds such support, to use it, 'supports_check_mode=True' must be passed to the constructor when creating the module object.
This patch adds support for check_mode to the dnszone management module, and provides tests to verify the behavior.
rjeffman
force-pushed
the
dnszone_add_check_mode_support
branch
from
7de95aa
to
a84071b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the required support for implementing
check_modein FreeIPABaseModule class, and adds support for
check_modeinipadnszone module.
Tests for verifying behavior were also added.