Use execute_ipa_commands for sudocmd plugins. #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
execute_ipa_commands replces the check mode exit, the loop over the generated commands and also in the member failure handling for modules with member support.
t-woerner
reviewed
Sep 14, 2021
plugins/modules/ipasudocmdgroup.py
Outdated
| @@ -100,7 +100,8 @@ | |||
| """ | |||
|
|
|||
| from ansible.module_utils.ansible_freeipa_module import \ | |||
| IPAAnsibleModule, compare_args_ipa, gen_add_del_lists, ipalib_errors | |||
| IPAAnsibleModule, compare_args_ipa, gen_add_del_lists, gen_add_list, \ | |||
| gen_intersection_list, ipalib_errors | |||
There was a problem hiding this comment.
The use of gen_add_list and gen_intersection_list to reduce to the needed changes only should also be mentioned. Maybe this could be an extra commit.
There was a problem hiding this comment.
Without gen_add_list and gen_intersection_list, the patch would be bigger, as a custom result_handler would be needed because of the already a member/not a member issue.
Do you think it is better to have a commit with the custom handler and another committ/PR removing it?
There was a problem hiding this comment.
You could add the change with gen_add_list and gen_intersection_list prior to the other one in the PR for example.
rjeffman
force-pushed
the
sudocmd_use_execute_ipa_commands
branch
2 times, most recently
from
fd6c7e2
to
31ff315
Compare
Use gen_add_list and gen_intersection_list for sudocmd member handling, to reduce the add lists to only the new and del lists only to existing entries. This enables to remove the ignores for "already a member" and "not a member" errors.
execute_ipa_commands replces the check mode exit, the loop over the generated commands and also in the member failure handling for modules with member support.
rjeffman
force-pushed
the
sudocmd_use_execute_ipa_commands
branch
from
31ff315
to
1615f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify ipasudocmd and ipasudocmdgroup to use
execute_ipa_commands.