hbacrule: Allow clearing members with empty lists. #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-woerner
reviewed
Feb 10, 2022
tests/hbacrule/test_hbacrule.yml
Outdated
Comment on lines
671
to
678
| host: | ||
| - "{{ 'testhost03.' + ipaserver_domain }}" | ||
| - "{{ 'testhost04.' + ipaserver_domain }}" | ||
| hostgroup: testhostgroup03,testhostgroup04 | ||
| user: testuser03,testuser04 | ||
| group: testgroup03,testgroup04 | ||
| hbacsvc: testhbacsvc03,testhbacsvc04 | ||
| hbacsvcgroup: testhbacsvcgroup03,testhbacsvcgroup04 |
There was a problem hiding this comment.
It might be good to add a test in the end to make sure that any of these entries are not there anymore after using the empty lists.
There was a problem hiding this comment.
I added two tests with check_mode: yes to verify if the attributes are empty.
I also refactored the playbook test so that the tests for empty members are in its own test playbook, reducing the size of the base test (which is still too big, IMO).
If a hbacrule member has any value, the only way to clear it is by
creating a task with 'state: absent' and 'action: member' and provide
a list with all the values for that member.
This patch allows the use of '<member>: []' with 'action: hbacrule'
to clear a hbacrule member.
A new test playbook can be found at:
tests/hbacrule/test_hbacrule_member_empty.yml
rjeffman
force-pushed
the
hbacrule_allow_clearing_members
branch
from
7e83e5b
to
19fc21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a hbacrule member has any value, the only way to clear it is by
creating a task with 'state: absent' and 'action: member' and provide
a list with all the values for that member.
This patch allows the use of ': []' with 'action: hbacrule'
to clear a hbacrule member.
Fix #751