-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New servicedelegationtarget management module #756
Conversation
6273318
to
4a62e84
Compare
…cipals This function will be used in servicedelegation target and rule modules to normalize principals given in the tasks. These can be service and host principals and also aliases. Note: The use of host principals requires IPA 4.9.0 or later. fail_json is called if the version is lower. servicedelegation_normalize_principals contains two embedded fuctions. One is normalize_principal_name that has been copied from ipaserver/plugins/servicedelegation.py, the other is the generic function _check_exists to be able to check if a host or service exists.
7922506
to
ad65ddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my comments are mostly cosmetic changes, but I'd like you to check the requested change on the member management logic.
ad65ddd
to
1e625d6
Compare
b80d462
to
28e6bae
Compare
There is a new servicedelegationtarget management module placed in the plugins folder: plugins/modules/ipaservicedelegationtarget.py The servicedelegationtarget module allows to ensure presence and absence of servicedelegationtargets and servicedelegationtarget members. Here is the documentation of the module: README-servicedelegationtarget.md New example playbooks have been added: playbooks/servicedelegationtarget/servicedelegationtarget-absent.yml playbooks/servicedelegationtarget/servicedelegationtarget-member-absent.yml playbooks/servicedelegationtarget/servicedelegationtarget-member-present.yml playbooks/servicedelegationtarget/servicedelegationtarget-present.yml New tests for the module: tests/servicedelegationtarget/test_servicedelegationtarget.yml tests/servicedelegationtarget/test_servicedelegationtarget_client_context.yml tests/servicedelegationtarget/test_servicedelegationtarget_hostprincipal.yml
28e6bae
to
a61c046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is a new servicedelegationtarget management module placed in the plugins
folder:
The servicedelegationtarget module allows to ensure presence and absence of
servicedelegationtargets and servicedelegationtarget members.
Here is the documentation of the module:
New example playbooks have been added:
New tests for the module: