Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAAnsibleModule: Provide base configuration for delete_continue. #761

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

rjeffman
Copy link
Member

@rjeffman rjeffman commented Feb 7, 2022

Allows the creation of IPAAnsibleModule objects with specific
ipa_arguments which are defined in a dictionary of argumets in
the base class.

Every module using delete_continue should provide the proper behavior
and the module must be instantiated with:

ansible_module = IPAAnsibleModule(
...,
ipa_arguments=["delete_continue"]
)

The plugin documentation must be extended with
'ipamodule_arguments.delete_continue'.

@t-woerner
Copy link
Member

Please create one commit. There are two with nearly the same message.

Allows the creation of IPAAnsibleModule objects with specific
`ipa_arguments` which are defined in a dictionary of argumets in
the base class.

Every module using `delete_continue` should provide the proper behavior
and the module must be instantiated with:

  ansible_module = IPAAnsibleModule(
      ...,
      ipa_arguments=["delete_continue"]
  )

The plugin documentation must be extended with
'ipamodule_arguments.delete_continue'.
@rjeffman
Copy link
Member Author

Please create one commit. There are two with nearly the same message.

Done.

Copy link
Member

@t-woerner t-woerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-woerner t-woerner merged commit 29badae into freeipa:master Feb 17, 2022
@rjeffman rjeffman deleted the delete_continue_module_utils branch August 25, 2022 14:14
@rjeffman rjeffman restored the delete_continue_module_utils branch August 25, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants