New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipaconfig: Add support for SID related attributes. #906
Conversation
The new parameters also need to be added to the README. |
Oh... my... sorry for that... |
af671eb
to
769832d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
643ce96
to
af02093
Compare
Since FreeIPA 4.9.8 the 'config_mod' command has parameters to enable and configure SIDs, and set the Netbios name. This patch adds the following parameters to ipaconfig plugin: enable_sids: New users and groups automatically get a SID assigned add_sids: Add SIDs for existing users and groups netbios_name: NetBIOS name of the IPA domain Both add_sids and netbios_name requires 'enable_sid: yes'. 'enable_sid' and 'netbios_name' are returned when querying IPA configuration. 'add_sids' always generate SIDs for users and groups, so, muiltiple executions of the playbook with 'add_sids: yes' will return 'changed', even if users and groups SIDs are not modified. A new test playbook is available: tests/config/test_config_sid.yml New examples playbooks are available: playbooks/config/change-ipa-domain-netbios-name.yml playbooks/config/generate-users-groups-sids.yml Fixes: freeipa#781 Related: https://bugzilla.redhat.com/show_bug.cgi?id=2069174 Related: https://bugzilla.redhat.com/show_bug.cgi?id=2069184
af02093
to
3c8d6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since FreeIPA 4.9.8 the 'config_mod' command has parameters to enable
and configure SIDs, and set the Netbios name.
This patch adds the following parameters to ipaconfig plugin:
enable_sids: New users and groups automatically get a SID assigned
add_sids: Add SIDs for existing users and groups
netbios_name: NetBIOS name of the IPA domain
Both add_sids and netbios_name requires 'enable_sid: yes'.
'enable_sid' and 'netbios_name' are returned when querying IPA
configuration.
'add_sids' always generate SIDs for users and groups, so, muiltiple
executions of the playbook with 'add_sids: yes' will return 'changed',
even if users and groups SIDs are not modified.
Fixes: #781
Related: https://bugzilla.redhat.com/show_bug.cgi?id=2069174
Related: https://bugzilla.redhat.com/show_bug.cgi?id=2069184