Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pki-healthcheck fails with 'Namespace' object has no attribute 'failures_only' with 0.6 #144

Closed
rcritten opened this issue Jul 28, 2020 · 0 comments
Closed

pki-healthcheck fails with 'Namespace' object has no attribute 'failures_only' with 0.6 #144

rcritten opened this issue Jul 28, 2020 · 0 comments

Comments

@rcritten
Copy link
Collaborator

Reported against Fedora 31 with freeipa-healthcheck-0.6-1 and pki-server-10.9.0-0.2.fc31

# pki-healthcheck
Traceback (most recent call last):
  File "/usr/sbin/pki-healthcheck", line 11, in <module>
    load_entry_point('pkihealthcheck==0.1', 'console_scripts', 'pki-healthcheck')()
  File "/usr/lib/python3.8/site-packages/pki/server/healthcheck/core/main.py", line 31, in main
    sys.exit(checks.run_healthcheck())
  File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/core.py", line 280, in run_healthcheck
    output = out(options)
  File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/output.py", line 102, in __init__
    super(JSON, self).__init__(options)
  File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/output.py", line 40, in __init__
    self.failures_only = options.failures_only
AttributeError: 'Namespace' object has no attribute 'failures_only'
rcritten added a commit to rcritten/freeipa-healthcheck that referenced this issue Jul 28, 2020
@rcritten
Allow consuming projects to not use all available options
31d34c1 
Some consumers of the framework may not be interested in the
filtering options. Don't fail if some or all of those are not
defined as options. Set logical defaults in this case.

freeipa#144

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
@rcritten rcritten mentioned this issue Jul 28, 2020
Merged
rcritten added a commit to rcritten/freeipa-healthcheck that referenced this issue Jul 29, 2020
@rcritten
Allow consuming projects to not use all available options
1edb5d1 
Some consumers of the framework may not be interested in the
filtering options. Don't fail if some or all of those are not
defined as options. Set logical defaults in this case.

freeipa#144

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten added a commit to rcritten/freeipa-healthcheck that referenced this issue Jul 29, 2020
@rcritten
Allow consuming projects to not use all available options
6e22e5a 
Some consumers of the framework may not be interested in the
filtering options. Don't fail if some or all of those are not
defined as options. Set logical defaults in this case.

freeipa#144

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten added a commit that referenced this issue Jul 29, 2020
@rcritten
Allow consuming projects to not use all available options
e62e05a 
Some consumers of the framework may not be interested in the
filtering options. Don't fail if some or all of those are not
defined as options. Set logical defaults in this case.

#144

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
cipherboy pushed a commit to cipherboy/pki that referenced this issue Jan 29, 2021
@rcritten @cipherboy
Fix missing options in PKI healthcheck
85c5841 
As reported by Pritam Singh in rh-bz#1922257, several options in
pki-healthcheck were missing. This was due to a recent change in
freeipa-healthcheck's core, making these arguments optional.

See also: freeipa/freeipa-healthcheck#144
Resolves: rh-bz#1922257

Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy pushed a commit to cipherboy/pki that referenced this issue Jan 29, 2021
@rcritten @cipherboy
Fix missing options in PKI healthcheck
5697c23 
As reported by Pritam Singh in rh-bz#1922257, several options in
pki-healthcheck were missing. This was due to a recent change in
freeipa-healthcheck's core, making these arguments optional. Fix
provided by Rob Crittenden via mail.

See also: freeipa/freeipa-healthcheck#144
Resolves: rh-bz#1922257

Signed-off-by: Alexander Scheel <ascheel@redhat.com>
@cipherboy cipherboy mentioned this issue Jan 29, 2021
Merged
cipherboy pushed a commit to cipherboy/pki that referenced this issue Feb 2, 2021
@rcritten @cipherboy
Fix missing options in PKI healthcheck
8080274 
As reported by Pritam Singh in rh-bz#1922257, several options in
pki-healthcheck were missing. This was due to a recent change in
freeipa-healthcheck's core, making these arguments optional. Fix
provided by Rob Crittenden via mail.

See also: freeipa/freeipa-healthcheck#144
Resolves: rh-bz#1922257

Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy pushed a commit to cipherboy/pki that referenced this issue Feb 3, 2021
@rcritten @cipherboy
Fix missing options in PKI healthcheck
28d80f2 
As reported by Pritam Singh in rh-bz#1922257, several options in
pki-healthcheck were missing. This was due to a recent change in
freeipa-healthcheck's core, making these arguments optional. Fix
provided by Rob Crittenden via mail.

See also: freeipa/freeipa-healthcheck#144
Resolves: rh-bz#1922257

Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy pushed a commit to dogtagpki/pki that referenced this issue Feb 4, 2021
@rcritten @cipherboy
Fix missing options in PKI healthcheck
c744c5f 
As reported by Pritam Singh in rh-bz#1922257, several options in
pki-healthcheck were missing. This was due to a recent change in
freeipa-healthcheck's core, making these arguments optional. Fix
provided by Rob Crittenden via mail.

See also: freeipa/freeipa-healthcheck#144
Resolves: rh-bz#1922257

Signed-off-by: Alexander Scheel <ascheel@redhat.com>
joeldavidparker added a commit to joeldavidparker/freeipa-healthcheck that referenced this issue Jun 24, 2022
@joeldavidparker
Allow consuming projects to not use all available options
b53b5c3 
Some consumers of the framework may not be interested in the
filtering options. Don't fail if some or all of those are not
defined as options. Set logical defaults in this case.

freeipa/freeipa-healthcheck#144

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
@rcritten rcritten closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcritten