Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipa-healthcheck --indent with large values causes 'Output raised MemoryError: ' #197

Closed
celestian opened this issue May 3, 2021 · 0 comments · Fixed by #288
Closed

ipa-healthcheck --indent with large values causes 'Output raised MemoryError: ' #197

celestian opened this issue May 3, 2021 · 0 comments · Fixed by #288
Assignees
@rcritten

Comments

@celestian
Copy link
Member

Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 8): Bug https://bugzilla.redhat.com/show_bug.cgi?id=1774037

Description of problem: ipa-healthcheck --indent with large values causes 'Output raised MemoryError: '


Version-Release number of selected component (if applicable):
[root@master ~]# rpm -q ipa-server
ipa-server-4.8.2-1.module+el8.2.0+4697+7171660c.x86_64
[root@master ~]# rpm -q ipa-server ipa-healthcheck
ipa-server-4.8.2-1.module+el8.2.0+4697+7171660c.x86_64
ipa-healthcheck-0.3-4.module+el8.1.0+4098+f286395e.noarch


How reproducible: Always

Steps to Reproduce:
1. Install ipa-server and ipa-healthcheck
2. Run the command with large values e.g

[root@master ~]# ipa-healthcheck --indent 1000000

Actual results:
[root@master ~]# ipa-healthcheck --indent 1000000
Output raised MemoryError: 

Expected results: indent values should have max values allowed so that MemoryError is not seen.
rcritten added a commit to rcritten/freeipa-healthcheck that referenced this issue Mar 28, 2023
@rcritten
Restrict the length of JSON output indent to 32
f8f9ac9 
Too big a value and the system will exhause memory. Normally I
trust users not to do things like but it doesn't hurt to constrain
sometimes.

Fixes: freeipa#197

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
@rcritten rcritten self-assigned this Mar 28, 2023
@rcritten rcritten mentioned this issue Mar 28, 2023
Merged
rcritten added a commit to rcritten/freeipa-healthcheck that referenced this issue Mar 28, 2023
@rcritten
Restrict the length of JSON output indent to 32
23a4af1 
Too big a value and the system will exhause memory. Normally I
trust users not to do things like but it doesn't hurt to constrain
sometimes.

Fixes: freeipa#197

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten added a commit to rcritten/freeipa-healthcheck that referenced this issue May 4, 2023
@rcritten
Restrict the length of JSON output indent to 32
3e45965 
Too big a value and the system will exhause memory. Normally I
trust users not to do things like but it doesn't hurt to constrain
sometimes.

Fixes: freeipa#197

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten added a commit that referenced this issue May 9, 2023
@rcritten
Restrict the length of JSON output indent to 32
9124c5c 
Too big a value and the system will exhause memory. Normally I
trust users not to do things like but it doesn't hurt to constrain
sometimes.

Fixes: #197

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcritten rcritten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict the length of JSON output indent to 32 rcritten/freeipa-healthcheck
2 participants
@celestian @rcritten