Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include tracebacks in the Result when catching outer-level problems #224

Closed
rcritten opened this issue Sep 3, 2021 · 0 comments
Closed

Include tracebacks in the Result when catching outer-level problems #224

rcritten opened this issue Sep 3, 2021 · 0 comments

Comments

@rcritten
Copy link
Collaborator

rcritten commented Sep 3, 2021

Healthcheck has a fail-safe so that if any of the checks raise an exception it is caught and logged so that one can be sure that all checks have run, even if not successfully. The problem is that the traceback is suppressed and often the exception message isn't very useful. Log the traceback both in debug mode and in the result itself to make tracking down the root cause a lot easier.
rcritten added a commit to rcritten/freeipa-healthcheck that referenced this issue Sep 3, 2021
@rcritten
Include an exception on outer-level failures when running plugins
a601ba1 
The traceback will be both in the debug output and within the
Result value for the call so we have half a chance to fix what
is broken.

freeipa#224

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
@rcritten rcritten mentioned this issue Sep 3, 2021
Merged
rcritten added a commit to rcritten/freeipa-healthcheck that referenced this issue Sep 17, 2021
@rcritten
Include an exception on outer-level failures when running plugins
80e7556 
The traceback will be both in the debug output and within the
Result value for the call so we have half a chance to fix what
is broken.

freeipa#224

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten added a commit that referenced this issue Feb 4, 2022
@rcritten
Include an exception on outer-level failures when running plugins
d9619c9 
The traceback will be both in the debug output and within the
Result value for the call so we have half a chance to fix what
is broken.

#224

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
joeldavidparker added a commit to joeldavidparker/freeipa-healthcheck that referenced this issue Jun 24, 2022
@joeldavidparker
Include an exception on outer-level failures when running plugins
94b0bb2 
The traceback will be both in the debug output and within the
Result value for the call so we have half a chance to fix what
is broken.

freeipa/freeipa-healthcheck#224

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcritten