Add a dirsrv requires to services that look up their names in LDAP #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcritten
added a commit
to rcritten/freeipa-healthcheck
that referenced
this pull request
Sep 28, 2023
Some services aren't included in ipaplaform.knownservices like smb and winbind. It is possible to discover the service name using the same method used by ipactl, via roles. If dirsrv isn't started then this will blow up spectacularly so use requires as a guard against it. Fixes: freeipa#301 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Some services aren't included in ipaplaform.knownservices like smb and winbind. It is possible to discover the service name using the same method used by ipactl, via roles. If dirsrv isn't started then this will blow up spectacularly so use requires as a guard against it. Fixes: freeipa#301 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
flo-renaud
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
@rcritten
thanks for the PR, works for me:
(venv) [root@server freeipa-healthcheck]# systemctl stop dirsrv@IPA-TEST.service
(venv) [root@server freeipa-healthcheck]# ipa-healthcheck
[
{
"source": "ipahealthcheck.meta.services",
"check": "dirsrv",
"result": "ERROR",
"uuid": "1466294d-c561-4adf-9443-e19308f2427c",
"when": "20231003085001Z",
"duration": "0.005170",
"kw": {
"status": false,
"msg": "dirsrv: not running"
}
}
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services aren't included in ipaplaform.knownservices like smb and winbind. It is possible to discover the service name using the same method used by ipactl, via roles.
If dirsrv isn't started then this will blow up spectacularly so use requires as a guard against it.
Fixes: #300