Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipatests: fix expected output for ipahealthcheck.meta.services #7022

Closed
wants to merge 1 commit into from
Closed

ipatests: fix expected output for ipahealthcheck.meta.services #7022

wants to merge 1 commit into from

Conversation

flo-renaud
Copy link
Contributor

ipa-healthcheck commit 31be12b introduced a change in the output
message when pki-tomcatd is not running.
With versions <= 0.12, the service name is displayed as
pki_tomcatd (with an underscore), but with 0.13+ it is
pki-tomcatd (with a dash).

Fixes: https://pagure.io/freeipa/issue/9460

@flo-renaud
Copy link
Contributor Author

The change was introduced with freeipa/freeipa-healthcheck@31be12b which is available in ipa-healthcheck 0.13 and 0.14

Adding backport labels for 4.10 and 4.11 (ipa 4.9 is tested against f36 which ships only ipa-healthcheck 0.12).

@flo-renaud flo-renaud added ipa-4-10 Mark for backport to ipa 4.10 ipa-4-11 Mark for backport to ipa 4.11 labels Sep 29, 2023
@flo-renaud
Copy link
Contributor Author

For future ref, link to runs:

  • with ipa-healthcheck 0.12: Details
  • with ipa-helthcheck 0.14: Details, the test is progressing further but failing because of ipa-healthcheck issue #300.

@rcritten
Copy link
Contributor

rcritten commented Oct 2, 2023

I have a candidate fix for the healthcheck issue, freeipa/freeipa-healthcheck#301

@flo-renaud
ipatests: fix expected output for ipahealthcheck.meta.services
5372471 
ipa-healthcheck commit 31be12b introduced a change in the output
message when pki-tomcatd is not running.
With versions <= 0.12, the service name is displayed as
pki_tomcatd (with an underscore), but with 0.13+ it is
pki-tomcatd (with a dash).

Fixes: https://pagure.io/freeipa/issue/9460

Signed-off-by: Florence Blanc-Renaud <flo@redhat.com>
@flo-renaud flo-renaud added the re-run Trigger a new run of PR-CI label Nov 11, 2023
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Nov 11, 2023
@flo-renaud
Copy link
Contributor Author

flo-renaud commented Nov 13, 2023 •
edited

For future ref, link to successful run with ipa-healthcheck 0.16: Details

Removing the temp commit.

@flo-renaud flo-renaud added the needs review Pull Request is waiting for a review label Nov 13, 2023
@rcritten rcritten self-assigned this Nov 13, 2023
@rcritten
Copy link
Contributor

This change LGTM.

@rcritten rcritten added ack Pull Request approved, can be merged pushed Pull Request has already been pushed and removed needs review Pull Request is waiting for a review labels Nov 13, 2023
@rcritten
Copy link
Contributor

master:

  • 07e5637 ipatests: fix expected output for ipahealthcheck.meta.services

@rcritten rcritten closed this Nov 13, 2023
This was referenced Nov 13, 2023
Closed
Closed
@flo-renaud flo-renaud deleted the t9460 branch November 14, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rcritten rcritten

Labels
ack Pull Request approved, can be merged ipa-4-10 Mark for backport to ipa 4.10 ipa-4-11 Mark for backport to ipa 4.11 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@flo-renaud @rcritten @freeipa-pr-ci